Make WordPress Core

Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#59401 closed defect (bug) (fixed)

Style engine: update docs for css_var

Reported by: ramonopoly's profile ramonopoly Owned by: isabel_brison's profile isabel_brison
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: Editor Keywords: has-patch gutenberg-merge
Focuses: Cc:

Description

The doc comments for css_var are topsy turvy.

The css_var property used to be this way, e.g., '--wp--preset--color--$slug' => 'color' , but then we swapped it around.

We should update the docs

Change History (9)

This ticket was mentioned in PR #5255 on WordPress/wordpress-develop by @ramonopoly.


7 months ago
#1

The doc comments for css_var were topsy turvy.

The css_var property used to be this way, e.g., '--wp--preset--color--$slug' => 'color' , but then we swapped it around.

Syncing Gutenberg commit from https://github.com/WordPress/gutenberg/pull/53710

Trac ticket: https://core.trac.wordpress.org/ticket/59401

#2 @isabel_brison
7 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 56630:

Editor: update docs for css_var.

Updates inline doc for the css_var key value pair in WP_Style_Engine.

Props ramonopoly.
Fixes #59401.

@isabel_brison commented on PR #5255:


7 months ago
#3

Committed inr56630

#4 @audrasjb
7 months ago

@isabel_brison @ramonopoly I'm not a native English speaker but "the following properties" seems to be the correct (or at least more consistent) form here.

This ticket was mentioned in PR #5256 on WordPress/wordpress-develop by @ramonopoly.


7 months ago
#5

Follow up to https://github.com/WordPress/wordpress-develop/pull/5255

A spelling error was detected but the PR was closed before changes could be made.

Props to @audrasjb and @tellthemachines

Trac ticket: https://core.trac.wordpress.org/ticket/59401

#6 @ramonopoly
7 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @isabel_brison
7 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 56640:

Editor: fix typo in css_var doc update.

Fixes a type in the doc update in [56630].

Props ramonopoly, audrasjb, costdev.
Fixes #59401.

@isabel_brison commented on PR #5256:


7 months ago
#8

Committed in r56640.

@ramonopoly commented on PR #5256:


7 months ago
#9

Whoopsies, thanks for fixing that!

I'll own the spelling error 👍🏻 My bl0d is typo

Thanks for committing!

Note: See TracTickets for help on using tickets.