Context Navigation

← Previous Ticket
Next Ticket →

#59401 closed defect (bug) (fixed)

Style engine: update docs for css_var

Reported by:	ramonopoly	Owned by:	isabel_brison
Priority:	normal	Milestone:	6.4
Component:	Editor	Version:	6.4
Severity:	normal	Keywords:	has-patch gutenberg-merge
Cc:		Focuses:

Description

The doc comments for css_var are topsy turvy.

The css_var property used to be this way, e.g., '--wp--preset--color--$slug' => 'color' , but then we swapped it around.

We should update the docs

Change History (9)

This ticket was mentioned in PR #5255 on WordPress/wordpress-develop by @ramonopoly.

3 years ago #1

The doc comments for css_var were topsy turvy.

The css_var property used to be this way, e.g., '--wp--preset--color--$slug' => 'color' , but then we swapped it around.

Syncing Gutenberg commit from https://github.com/WordPress/gutenberg/pull/53710

Trac ticket: https://core.trac.wordpress.org/ticket/59401

#2 @isabel_brison
3 years ago

Owner set to isabel_brison
Resolution → fixed
Status new → closed

In 56630:

Editor: update docs for css_var.

Updates inline doc for the css_var key value pair in WP_Style_Engine.

Props ramonopoly.
Fixes #59401.

@isabel_brison commented on PR #5255:

3 years ago #3

Committed inr56630

#4 @audrasjb
3 years ago

@isabel_brison @ramonopoly I'm not a native English speaker but "the following properties" seems to be the correct (or at least more consistent) form here.