Undefined and unused variable in WP_Test_Stream::mkdir

[david.binda]

The $file variable is undefined in https://core.trac.wordpress.org/browser/trunk/tests/phpunit/includes/class-wp-test-stream.php?rev=55017#L206

Further, the $plainfile is not being used: https://core.trac.wordpress.org/browser/trunk/tests/phpunit/includes/class-wp-test-stream.php?rev=55017#L204

Since I haven't been able to find a test which would be using the mkdir method of the stream wrapper, I'm unable to tell what would be the best approach to fix the method, since replacing the $file by $this->file nor by $plaifile does not seem to prevent repeated directory creations.

I'm attaching a patch which, IMHO, makes the method to work, but I'm not sure if it's the best approach.

Trac ticket: 59406

---
This ticket already has a patch. I have just updated the current patch. Looking for suggestion.

[SergeyBiryukov]

Thanks for the ticket! Introduced in [49230] / #42663.

Replying to david.binda:

Since I haven't been able to find a test which would be using the mkdir method of the stream wrapper, I'm unable to tell what would be the best approach to fix the method, since replacing the $file by $this->file nor by $plaifile does not seem to prevent repeated directory creations.

At a glance, it seems like the intention was to prevent directory creation if there is already a file with the same name. However, repeated directory creations should probably be prevented too, that would be consistent with the PHP mkdir() implementation.

So I think the patch may need some adjustment to do both.

Preventing the creation of duplicate directories of the mkdir() function

Trac ticket: https://core.trac.wordpress.org/ticket/59406

[rajinsharwar]

Added the check for duplicate directories as well @SergeyBiryukov in the current patch.

[SergeyBiryukov]

In 56998:

Tests: Correct the WP_Test_Stream::mkdir() method.

The method attempted to check if there is already a file with the same name, however the conditional used an undefined variable.

This commit prevents directory creation if a file or directory with the same name already exists, bringing consistency with the PHP mkdir() implementation.

Includes adding missing documentation for the method.

Reference: ​PHP Manual: streamWrapper::mkdir().

Follow-up to [49230].

Props david.binda, sadizaman, rajinsharwar, SergeyBiryukov.
Fixes #59406.

[SergeyBiryukov]

Since it's not a regression in 6.4, I think this ticket can be moved to 6.5 and does not need a backport.

Thanks for the PR! Merged in r56998.

Thanks for the PR! Merged in r56998.