Opened 15 months ago
Last modified 15 months ago
#59427 new defect (bug)
Need to updated image-edit.php file code for Crop.
Reported by: | upadalavipul | Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | reporter-feedback needs-patch |
Focuses: | Cc: |
Description
I have reviewed the code of the theme and I found the image-edit.php file code is breaking. please check the below attachment of my patch.
Attachments (1)
Change History (4)
#2
@
15 months ago
- Keywords needs-patch added
- Version set to 6.3.1
Hello @TobiasBg
True. Removing "" Does not make sense and it wont work. still I have tested and notice that patch isn't working
Test Report for - https://core.trac.wordpress.org/attachment/ticket/59427/59427.patch
Environment:
============
WordPress - V6.3.1
Active plugins - None
Os: Windows
Browser: Chrome
How to reproduce bug:
========
- Add new page
- Add image widget
- Choose Random image
- Click on Crop (https://prnt.sc/TERVy99RzgcE)
- Apply any size and click apply you will see an error (https://prnt.sc/XgP6IUIN-h61)
Expected Output
========
- Cropped part of the image should be apply to the image
Status - Patch Not Working:
========
https://core.trac.wordpress.org/attachment/ticket/59427/59427.patch
#3
@
15 months ago
- Version 6.3.1 deleted
Hi @mayur8991,
thanks for testing this patch and for providing these instructions. @upadalavipul, is this the same procedure (and error) that you are trying to fix with this patch?
I have a feeling that this might be something else, as the image-edit.php file that is in the patch actually adds a different user interface than what's shown in @mayur8991's video.
(Note that I'm removing the "Version" from the ticket's metadata again, as that should then be set to the version in which a potential bug was introduced.)
Hi @upadalavipul, thanks for opening this ticket!
Can you please clarify what exactly is breaking in this file for you? Are you getting error messages? Is this with a stock installation of WordPress 6.3.1, with all plugins deactivated?
Removing the quotation marks as in your patch (especially the the
'
) will not work. The value of the$nonce
variable needs to be passed as a string in that JavaScript call, whereas it will be treated as a variable name itself with your proposed change.