WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#5943 closed defect (bug) (fixed)

Buttons in admin area needs a cursor definition

Reported by: ionfish Owned by: iammattthomas
Milestone: 2.5 Priority: high
Severity: normal Version: 2.5
Component: Administration Keywords: has-patch needs-commit
Focuses: Cc:

Description

.button et al. need a cursor property; the cursor shows as an arrow when you mouseover, rather than a pointer. Issue appears in Safari 3 and Firefox 2 (both on a Mac).

Attachments (2)

cursorfix.diff (305 bytes) - added by ionfish 6 years ago.
5943.diff (323 bytes) - added by iammattthomas 6 years ago.
Re-apply pointer cursor for buttons.

Download all attachments as: .zip

Change History (15)

ionfish6 years ago

comment:1 ionfish6 years ago

  • Summary changed from Buttons in admin area are missing a cursor to Buttons in admin area need a cursor definition

Slight clarification of issue summary.

comment:2 ionfish6 years ago

  • Summary changed from Buttons in admin area need a cursor definition to Buttons in admin area needs a cursor definition

Spelling.

comment:3 mdawaffe6 years ago

  • Owner changed from anonymous to iammattthomas
  • Priority changed from normal to high

+1

If we're not going to have the buttons look "buttony", a pointer cursor makes the interaction seem way more natural.

With :hover color shift as the only visual feedback, I have no idea what's going to happen if I click the mouse. It makes me think some kind of javascript nonsense is about to happen :)

comment:4 iammattthomas6 years ago

  • Cc rboren added

I agree. Let's patch it up.

comment:5 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7040]) Add cursor pointer to buttons. Props ionfish. fixes #5943

comment:6 mdawaffe6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Matt reverted this with [7184]. I disagree.

comment:7 zamoose6 years ago

I agree with mdawaffe's disagreement.

comment:8 iammattthomas6 years ago

Agree with mdawaffe -- there are places where buttons are inputs, and places where buttons are text links. If we don't specify the pointer cursor for all, they won't be consistent, and for no apparent reason to the user.

comment:9 iammattthomas6 years ago

  • Cc matt added; rboren removed

comment:10 iammattthomas6 years ago

  • Cc rboren added; matt removed

Happy Cog says the pointer cursor is the way to go. Can rboren just re-apply this patch?

comment:11 ionfish6 years ago

  • Keywords needs-commit added

Bit confused as to why this was reverted at all, but can it be reinstated please? Buttons lacking a proper cursor is a usability nightmare.

comment:12 ryan6 years ago

Create a fresh patch and I'll get it in.

iammattthomas6 years ago

Re-apply pointer cursor for buttons.

comment:13 ryan6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [7215]) Add cursor pointer to buttons. Props ionfish and mt. fixes #5943

Note: See TracTickets for help on using tickets.