Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #59450, comment 3


Ignore:
Timestamp:
09/26/2023 01:09:45 PM (3 years ago)
Author:
Cybr
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #59450, comment 3

    initial v1  
    11The `1e4` iterations are not part of the benchmark but the warmup. I found that the website shows inconsistent numbers, probably due to the way `hrtime()` interacts with the server or how it lazy loads PCRE -- I cannot tell. If you flip the warmup tests, the second will always be slower during -- everything thereafter is indicative of real-world performance. I should exclude those from the output in the future to alleviate confusion about this quirk.
    22
    3 The point I'm making about not writing to variables is that the entire codebase is trying to write variables before reading them. This often happens needlessly, also in `apply_filters()`, albeit obscure: https://wordpress.slack.com/archives/C02RQBWTW/p1695251506451989.
     3The point I'm making about not writing to variables is that the entire codebase is trying to write variables before reading them. This often happens needlessly, also in `apply_filters()`, albeit obscure: https://wordpress.slack.com/archives/C02RQBWTW/p1695251506451989. This is the aftermath of supporting PHP 5.2 for far too long, accumulating code debt that should be undone.