Make WordPress Core

Opened 9 months ago

Last modified 5 weeks ago

#59457 new defect (bug)

Twenty Nineteen: Calendar block does not have theme preset text colors in the editor

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-refresh
Focuses: Cc:

Description

Steps to reproduce the issue :-

  1. Activate Twenty Nineteen theme.
  2. Choose Calendar block.
  3. Apply text color from inspector.

You can able to see the choosen font color front side but in editor side it may not change as per the selected color.

I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/DlNN9jMJzk7KJcYP4L44

Attachments (1)

59457.patch (1.3 KB) - added by nidhidhandhukiya 9 months ago.

Download all attachments as: .zip

Change History (5)

#1 @karmatosed
2 months ago

  • Keywords has-patch needs-testing added

#2 @karmatosed
5 weeks ago

  • Keywords needs-refresh added; needs-testing removed

Whilst I can see this issue, I think that a gentler approach might be needed. I am not convinced about adding so many hardcoded colors. What other options have you considered based on inherit for example or other options @nidhidhandhukiya?

#3 @karmatosed
5 weeks ago

  • Milestone changed from Awaiting Review to Future Release

#4 @sabernhardt
5 weeks ago

  • Summary changed from Twenty Nineteen - Calendar block having issue with text color editor side. to Twenty Nineteen: Calendar block does not have theme preset text colors in the editor

The editor styles do not include the text color classes for any block or element to inherit the color. The patch on #49787 is currently focused on the mark element for highlighted text, but it sets text colors in the editor and adjusts them (in PHP) when someone changes the theme's primary color.

If possible, it would be nice to have one patch that works with any element.

Note: See TracTickets for help on using tickets.