Close ZIP archives before returning in `_unzip_file_ziparchive()`.

[costdev]

In ​_unzip_file_ziparchive(), the archive is opened, but there are several returns that don't close the archive beforehand.

From the PHP manual on ZipArchive::close():

This method is automatically called at the end of the script.
​Reference

and from the documentation for the underlying zip_close() from libzip:

If successful, archive is freed. Otherwise archive is left unchanged and must still be freed.
​Reference

As this function is used during installation and upgrade processes which are memory-intensive, let's free the archive before each of the return statements, rather than waiting until the end of the script.

Note: The return that gets used as a result of true !== $zopen does not need a call to $z->close(), as freeing the archive is ​handled internally by libzip's zip_open().

---

• Originally introduced in [13005].
• Follow-up to: [13005], [13006], [13015], [13221], [14346] [25779].

There are several early returns in _unzip_file_ziparchive() which don't close the archive prior to returning.

As this function is used in installation and upgrade processes which are memory-intensive, this calls ZipArchive::close() to free the archive prior to each early return. This excludes the first return which is a result of a failure to open the archive, which is freed internally when the failure occurs.

References:

• PHP.net: ​ZipArchive::open() and ​ZipArchive::close()
• libzip: ​zip_open() and ​zip_close()

[afragen]

Looks good from our previous discussion. 😉

[costdev]

In 56735:

Filesystem API: Free the archive in _unzip_file_ziparchive().

There are several early returns in _unzip_file_ziparchive() which don't close the archive prior to returning.

As this function is used in installation and upgrade processes which are memory-intensive, this calls ZipArchive::close() to free the archive prior to each early return. This excludes the first return which is a result of a failure to open the archive, which is ​freed internally when the failure occurs.

References:

• PHP.net: ​ZipArchive::open() and ​ZipArchive::close()
• libzip: ​zip_open() and ​zip_close()

Follow-up to: [13005], [13006], [13015], [13221], [14346] [25779].

Props azaozz, afragen, joemcgill, costdev.
Fixes #59467

Committed in r56735.