WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#59473 closed defect (bug) (fixed)

Unwanted space at the end of the string

Reported by: azharckra Owned by: hellofromTonya
Priority: normal Milestone: 6.4
Component: Text Changes Version: 6.0
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

Unwanted space at the end of the string and shows a warning in the translation.
https://i.snipboard.io/R6Brzs.jpg

Change History (7)

This ticket was mentioned in ​PR #5327 on ​WordPress/wordpress-develop by ​@azharckra.
3 years ago #1

  • Keywords has-patch added

Removed unwanted space at the end of the string.

Removed unwanted space at the end of the string.

Trac ticket: https://core.trac.wordpress.org/ticket/59473

#2 @mukesh27
3 years ago

  • Focuses accessibility removed
  • Type enhancement → defect (bug)
  • Version → 6.0

Good catch, introduced in [53182] / #52970.

#3 @mukesh27
3 years ago

  • Milestone Awaiting Review → 6.4

Move to 6.4 as it straightforward change.

​@kebbet commented on ​PR #5327:
3 years ago #4

PR looks good to me, I double checked that the following strings does not need that extra space. Good catch!

#5 @hellofromTonya
3 years ago

  • Keywords commit added
  • Owner set to hellofromTonya
  • Status new → reviewing

Hello @azharckra,

Welcome to WordPress Core's Trac. Good catch! Thank you for finding the issue and creating a patch to resolve it :)

​Your patch has several approves already and LGTM too. Marking it for commit.

#6 @hellofromTonya
3 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 56734:

Text Changes: Remove empty space in Erase Personal Data help tab.

Improves the text by removing an empty space at the end of a string within the "Default Data" help tab of the "Erase Personal Data".

Props azharckra, kebbet, krupalpanchal, mukesh27.

Follow-up to [53182].
Fixes #59473.

​@hellofromTonya commented on ​PR #5327:
3 years ago #7

Committed via changeset https://core.trac.wordpress.org/changeset/56734. Thank you everyone for your contributions :)

Note: See TracTickets for help on using tickets.