Opened 3 years ago
Closed 3 years ago
#59501 closed defect (bug) (fixed)
Need to add space In Theme Activation Message
| Reported by: | shailu25 | Owned by: | joedolson |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.4 |
| Component: | Themes | Version: | 6.4 |
| Severity: | minor | Keywords: | has-patch has-screenshots commit |
| Cc: | Focuses: |
Description
When a new theme is activated, the message currently displayed reads: "New theme activated.Visit site."
Need to add space between "New theme activated." and the "Visit site" link.
Attachments (5)
Change History (15)
#2
@
3 years ago
- Milestone Awaiting Review → 6.4
- Owner set to
- Status new → accepted
- Type enhancement → defect (bug)
This is a follow up to #57791.
#3
@
3 years ago
Thanks for the patch!
We can avoid extra concatenation here and just insert the space before the link: '<a href="' → ' <a href="'.
#6
@
3 years ago
We get same error for Settings saved and theme activated. message. Check https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/themes.php#L274
#8
@
3 years ago
Thanks everyone for your contributions. 59501.3.patch LGTM and resolves the feedback mentioned. Looks ready for commit.
Hey @joedolson are you planning to commit it today for Beta 2?
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Patch Added