Make WordPress Core

Opened 8 months ago

Closed 8 months ago

#59501 closed defect (bug) (fixed)

Need to add space In Theme Activation Message

Reported by: shailu25's profile shailu25 Owned by: joedolson's profile joedolson
Milestone: 6.4 Priority: normal
Severity: minor Version: 6.4
Component: Themes Keywords: has-patch has-screenshots commit
Focuses: Cc:

Description

When a new theme is activated, the message currently displayed reads: "New theme activated.Visit site."

Need to add space between "New theme activated." and the "Visit site" link.

Attachments (5)

59501.patch (615 bytes) - added by shailu25 8 months ago.
Patch Added
before-patch.png (333.2 KB) - added by shailu25 8 months ago.
Before Patch
After-patch.png (340.8 KB) - added by shailu25 8 months ago.
After Patch
59501.2.patch (610 bytes) - added by shailu25 8 months ago.
Patch Updated
59501.3.patch (1.1 KB) - added by shailu25 8 months ago.
Updated Patch

Download all attachments as: .zip

Change History (15)

@shailu25
8 months ago

Patch Added

@shailu25
8 months ago

Before Patch

@shailu25
8 months ago

After Patch

#1 @shailu25
8 months ago

  • Keywords has-screenshots added

#2 @joedolson
8 months ago

  • Milestone changed from Awaiting Review to 6.4
  • Owner set to joedolson
  • Status changed from new to accepted
  • Type changed from enhancement to defect (bug)

This is a follow up to #57791.

#3 @SergeyBiryukov
8 months ago

Thanks for the patch!

We can avoid extra concatenation here and just insert the space before the link: '<a href="'' <a href="'.

@shailu25
8 months ago

Patch Updated

#4 @shailu25
8 months ago

I have Updated Patch as per mentioned in above comment.

#5 @SergeyBiryukov
8 months ago

  • Keywords commit added

Thanks! Looks good to me :)

#6 @mukesh27
8 months ago

We get same error for Settings saved and theme activated. message. Check https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/themes.php#L274

@shailu25
8 months ago

Updated Patch

#7 @shailu25
8 months ago

I have Updated Patch as per above comment.

#8 @hellofromTonya
8 months ago

Thanks everyone for your contributions. 59501.3.patch LGTM and resolves the feedback mentioned. Looks ready for commit.

Hey @joedolson are you planning to commit it today for Beta 2?

#9 @joedolson
8 months ago

With the one hour code freeze, I won’t have time.

#10 @joedolson
8 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 56800:

Administration: Add missing space in theme activation notices.

Restore missing space in two admin notices during theme activation.

Props shailu25, sergeybiryukov, mukesh27, hellofromtonya.
Fixes #59501. See #57791.

Note: See TracTickets for help on using tickets.