Add more context to split_the_query filter

[spacedmonkey]

Current the split_the_query filter has the current WP_Query instance as context. However to calculate the value you need the value variables.

• $old_request
• $limits
• $fields
• $q ( query arguments ).

It is worth noting that $this->request can be received by WP_Query instance and $wpdb->posts can be received from global $wpdb.

With this extra context, will be make the filter much more useful.

Trac ticket: https://core.trac.wordpress.org/ticket/59514

[spacedmonkey]

Ping @tillkruess for review.

[tillkruess]

Huge +1. No downsides.

[audrasjb]

Hi there, so you think this one can be committed in time for beta 1 tomorrow?

Also please note that the @since mention needs to be updated in the docblock.

[rcorrales]

Hi, attached is a patch with similar changes as the current PR, but adding the @since to the docblock and removing the $q parameter as it is available through $query->query_vars.

[audrasjb]

As per today's pre-release party check, let's move this one to milestone 6.6 as we're very close to release 6.5 beta 1.

[oglekler]

@spacedmonkey, can you proceed with the patch?

[shailu25]

Refreshed Patch

[shailu25]

Refreshed Patch.

[shailu25]

I have refreshed the patch & also changed in docs. Added @since 6.6.0 instead of @since 6.5.0.

Patch: https://core.trac.wordpress.org/attachment/ticket/59514/59514.2.patch

[spacedmonkey]

In 58180:

Query: Add more context to the split_the_query filter.

Add more context to the split_the_query filter by adding two new parameters: '$old_request' and '$clauses'. This enriches the filter with additional information about the SQL query before the query is run, enabling developers to have more context to help decide if a query should be split.

Props spacedmonkey, shailu25, rcorrales, tillkruess.
Fixes #59514.