Context Navigation

← Previous Ticket
Next Ticket →

#59526 closed defect (bug) (fixed)

Twenty Twenty-Four: Fix image assets

Reported by:	onemaggie	Owned by:	hellofromTonya
Priority:	normal	Milestone:	6.4
Component:	Bundled Theme	Version:	6.4
Severity:	normal	Keywords:
Cc:		Focuses:

Description

After renaming a few of the images we need to give them the same treatment as https://core.trac.wordpress.org/changeset/56721 so that they show up for users and include the right content.

The files affected are:

abstract-geometric-art.webp
building-exterior.webp
hotel-facade.webp
museum.webp
tourist-and-building.webp
windows.webp

Change History (8)

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.

3 years ago

#2 @hellofromTonya
3 years ago

Component General → Bundled Theme
Milestone Awaiting Review → 6.4

Moving into 6.4. Thank you.

This ticket was mentioned in Slack in #core by colorful-tones. View the logs.

3 years ago

#4 @shailu25
3 years ago

#59531 was marked as a duplicate.

#5 @hellofromTonya
3 years ago

Owner set to hellofromTonya
Status new → assigned
Version → trunk

References:

[56764] for #59524's patch.

As @desrosj noted in Make/Core slack:

Ya this is because patches do not include binary file contents. So images and font files that get added do not always make it into local environments when staging a patch or PR.

It's a limitation to GIT/SVN, as far as I know

Last edited 3 years ago by hellofromTonya (previous) (diff)

#6 @hellofromTonya
3 years ago

Resolution → fixed
Status assigned → closed

In 56775:

Twenty Twenty-Four: Fix 6.4 Beta 2 image assets.

Fixes the image assets from [56764] for the images to properly render.

Adds binary file contents (resolves 0 bytes issue) and svn:mime-type property:

abstract-geometric-art.webp
building-exterior.webp
hotel-facade.webp
museum.webp
tourist-and-building.webp
windows.webp

Updates the binary file contents for renamed images:

angular-roof.webp
art-gallery.webp
green-staircase.webp

Follow-up to [56764].

Unprops hellofromTonya.
Props onemaggie, luminuu, colorful-tones, desrosj, mukesh27, nendeb55, nicolefurlan, satishprajapati, shailu25.
Fixes #59526.
See #59524.

#7 @costdev
3 years ago

#59567 was marked as a duplicate.

This ticket was mentioned in Slack in #core by ironprogrammer. View the logs.

3 years ago

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#59526 closed defect (bug) (fixed)

Twenty Twenty-Four: Fix image assets

Description

Change History (8)

This ticket was mentioned in ​Slack in #core by hellofromtonya. ​View the logs. 3 years ago

#2 @hellofromTonya 3 years ago

This ticket was mentioned in ​Slack in #core by colorful-tones. ​View the logs. 3 years ago

#4 @shailu25 3 years ago

#5 @hellofromTonya 3 years ago

#6 @hellofromTonya 3 years ago

#7 @costdev 3 years ago

This ticket was mentioned in ​Slack in #core by ironprogrammer. ​View the logs. 3 years ago