New filter admin_canonical_url

[prionkor]

Admin canonical url is often problematic and there are few open ticket related to it. A good choice will be providing a filter so people can modify it if needed.

Related #35561

Trac ticket:

https://core.trac.wordpress.org/ticket/59545

Related PR ​https://github.com/WordPress/wordpress-develop/pull/1504

Trac ticket:

[prionkor]

PR added in github:

​https://github.com/WordPress/wordpress-develop/pull/5412

[audrasjb]

Thanks for the ticket and patch. I added two change requests in the PR :)

[prionkor]

Done! Thanks for the review!

The failed test is timeout and not relevant to the change. What is the next step?

The failed test is timeout and not relevant to the change. What is the next step?

No worries, it clearly appears that it is a timeout, so this is not a blocker.

[jefferyto]

The fact that #35561 has been open for 8 years and hasn't had any meaningful attention from a core committer for almost as long...

Compared with the near instantaneous acceptance of this change, a way for people to *work around* the issue that continues to exist in the codebase...

Which will then become the de-facto "solution" whenever someone encounters the same problem, allowing the core project to continue to at best ignore this and other similar issues (#36201 comes to mind) and at worst pretend the issues don't exist (since people will work around the problems and move on with their lives instead of pointlessly opening or commenting on issues here)...

...it simply boggles the mind.

[devmuhib]

Do we need to test this or it's already accepted?

[audrasjb]

In 57595:

Canonical: Introduce admin_canonical_url filter.

This changeset introduces the new admin_canonical_url hook to help developers and extenders to modify the admin canonical url value.

Props prionkor, audrasjb.
Fixes #59545.

committed in https://core.trac.wordpress.org/changeset/57595

[audrasjb]

Adding needs-dev-note to ensure this changeset is mentioned in the misc changes dev note.

[peterwilsoncc]

I think this filter would be better named wp_admin_canonical_url:

• prefixes are a good thing
• it matches the function name it's filtering the output of

Sorry I didn't notice this until after the commit but it's impossible to track everything.

[shailu25]

Patch Updated

[shailu25]

Changed filter name(wp_admin_canonical_url) as per suggested in above comment.

[swissspidy]

In 57651:

Canonical: Rename admin_canonical_url filter to wp_admin_canonical_url.

This improves consistency as it matches the name of the function it is used in.

Props peterwilsoncc, shailu25.
Fixes #59545.