Opened 14 months ago
Closed 10 months ago
#59545 closed enhancement (fixed)
New filter admin_canonical_url
Reported by: | prionkor | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Canonical | Keywords: | has-patch needs-dev-note |
Focuses: | administration | Cc: |
Description
Admin canonical url is often problematic and there are few open ticket related to it. A good choice will be providing a filter so people can modify it if needed.
Related #35561
Attachments (1)
Change History (18)
This ticket was mentioned in PR #5412 on WordPress/wordpress-develop by prionkor.
14 months ago
#1
- Keywords has-patch added
#3
@
14 months ago
- Keywords changes-requested added
Thanks for the ticket and patch. I added two change requests in the PR :)
@audrasjb commented on PR #5412:
14 months ago
#7
The failed test is timeout and not relevant to the change. What is the next step?
No worries, it clearly appears that it is a timeout, so this is not a blocker.
#8
@
14 months ago
- Keywords dev-feedback removed
- Milestone changed from Awaiting Review to 6.5
- Owner set to audrasjb
- Status changed from new to accepted
#9
@
14 months ago
The fact that #35561 has been open for 8 years and hasn't had any meaningful attention from a core committer for almost as long...
Compared with the near instantaneous acceptance of this change, a way for people to *work around* the issue that continue to exist in the codebase...
Which will then become the de-facto "solution" whenever someone encounters the same problem, allowing the core project to continue to at best ignore this and other similar issues (#36201 comes to mind) and at worst pretend the issues don't exist (since people will work around the problems and move on with their lives instead of pointlessly opening or commenting on issues here)...
...it simply boggles the mind.
@audrasjb commented on PR #5412:
10 months ago
#13
committed in https://core.trac.wordpress.org/changeset/57595
#14
@
10 months ago
- Keywords needs-dev-note added
Adding needs-dev-note
to ensure this changeset is mentioned in the misc changes dev note.
#15
@
10 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
I think this filter would be better named wp_admin_canonical_url
:
- prefixes are a good thing
- it matches the function name it's filtering the output of
Sorry I didn't notice this until after the commit but it's impossible to track everything.
#16
@
10 months ago
I have added Patch as per suggested in above comment.
Trac ticket:
https://core.trac.wordpress.org/ticket/59545
Related PR https://github.com/WordPress/wordpress-develop/pull/1504
Trac ticket: