Make WordPress Core

Opened 8 months ago

Closed 5 months ago

Last modified 5 months ago

#59548 closed defect (bug) (wontfix)

Need update unused $errormsg variables on the rss.php file.

Reported by: upadalavipul's profile upadalavipul Owned by:
Milestone: Priority: normal
Severity: trivial Version:
Component: Feeds Keywords:
Focuses: coding-standards Cc:

Description

I have reviewed the code and found the return $errormsg variable is commenting. if it is not used then we can remove it variable and related content. if we need to use it in the future then need to related content code commenting. As of now I related code is commenting. please review the below attached patch.

Attachments (2)

59548.patch (1.2 KB) - added by upadalavipul 8 months ago.
59548.1.patch (1.0 KB) - added by sabernhardt 5 months ago.
removing code that was commented out and the $errormsg variable in _response_to_rss()

Download all attachments as: .zip

Change History (5)

@upadalavipul
8 months ago

#1 @sabernhardt
7 months ago

  • Component changed from General to Feeds
  • Keywords 2nd-opinion added
  • Severity changed from normal to minor

#57107 may remove much more code from the deprecated MagpieRSS file.

If the no-op plan is delayed or undesired, there would be a small value in removing those 'commented out' lines with obsolete error functions:
line 414
line 426
lines 527 to 528
line 624

#2 @SergeyBiryukov
6 months ago

  • Keywords close added

Hi there, thanks for the ticket!

Please note that wp-includes/rss.php is a former external library (MagpieRSS), which is deprecated and may be removed in the future as per #57107.

@sabernhardt
5 months ago

removing code that was commented out and the $errormsg variable in _response_to_rss()

#3 @sabernhardt
5 months ago

  • Keywords 2nd-opinion close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Severity changed from minor to trivial
  • Status changed from new to closed

I agree to close the ticket because the small edits I suggested have such a low value, though I uploaded a patch to show that in case someone thinks it is worth the changeset.

Of course, the code would be much cleaner than that if functions such as fetch_rss() and _response_to_rss() simply would return false (or have some other no-op method).

Last edited 5 months ago by sabernhardt (previous) (diff)
Note: See TracTickets for help on using tickets.