Twenty Nineteen: The required WordPress versions do not match

[poena]

In the readme, style.scss and style.css files, the required WordPress version is set to 4.9.6:

Requires at least: 4.9.6

But in functions.php, the minimum version is 4.7.
It has been 4.7 since #45424.

/**
 * Twenty Nineteen only works in WordPress 4.7 or later.
 */
if ( version_compare( $GLOBALS['wp_version'], '4.7', '<' ) ) {
	require get_template_directory() . '/inc/back-compat.php';
	return;
}

Since there may already be installations on 4.7, the file headers should be updated to say 4.7.

​A previous conversation about the required version mentions that the version needs to be 4.9.6 because the theme uses the_privacy_policy_link(). But the_privacy_policy_link() is wrapped inside a function_exist:

if ( function_exists( 'the_privacy_policy_link' ) ) {
	the_privacy_policy_link( '', '<span role="separator" aria-hidden="true"></span>' );
}

Other relevant discussions:
​https://github.com/WordPress/twentynineteen/issues/431
​https://github.com/WordPress/twentynineteen/pull/432

[audrasjb]

Hello Carolina :)

Since the_privacy_policy_link() is wrapped inside a function_exists check, I don't think it is relevant to require 4.9.6. Let's update to 4.7 everywhere.

This PR will update the Requires at least to 4.7 everywhere.

[huzaifaalmesbah]

Thank you for creating the ticket. You raised a good point.

I'm not able to remove #b251590 commit. Please ignore that commit and rest of the commits are fine.

[nicolefurlan]

@poena does this PR look good? Does this need testing or is it ready for commit?

Hi @kafleg

There are one more instance need to change in readme.txt file its also need to change 4.7 instead of 4.9.6. can you please update it ?

[oglekler]

This is simple enough (or it looks like it) and can be done quickly, so, I am keeping it in the current milestone for now.

[nicolefurlan]

This ticket was discussed in today's bug scrub.

@kafleg would you be able to update the PR ASAP so that we could get this included in the 6.4 release?

@felipeelia also said they would be willing to help.

Same as ​https://github.com/WordPress/wordpress-develop/pull/5422 but addressing ​shail-mehta comment.

Trac ticket: https://core.trac.wordpress.org/ticket/59557

[kafleg]

Hi @nicolefurlan

Oakay, doing it today.

[kafleg]

Thank you for doing it @felipeelia.

Thank you for adding the commit for the remaining update. It looks good to me.

Thank you @felipeelia for Updating Remaining changes
It looks good to me.

[SergeyBiryukov]

In 56952:

Twenty Nineteen: Correct the required WordPress version in theme headers.

The required version was previously set to two different values:

• 4.7 in the theme's functions.php file.
• 4.9.6 in theme headers, because of the the_privacy_policy_link() function usage in footer.php.

However, as the_privacy_policy_link() call is wrapped in a function_exists() check, it does not affect the requirements in practice.

This commit aims to correct the discrepancy by updating theme headers to match the actual required WP version.

Follow-up to [43808], [43892].

Props poena, kafleg, felipeelia, audrasjb, huzaifaalmesbah, shailu25, nicolefurlan, oglekler.
Fixes #59557.

Thanks for the PR! Merged in r56952.

Thanks for the PR! Merged in r56952.