Make WordPress Core

Opened 7 months ago

Closed 5 months ago

#59563 closed enhancement (fixed)

Improve translation strings

Reported by: rabmalin's profile rabmalin Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.3
Component: I18N Keywords:
Focuses: Cc:

Description

/wp-includes/class-wp-duotone.php L904

__( 'The duotone id "%s" is not registered in theme.json settings' ),

theme.json is never going to be translated in another languages. Would it make more sense if we take that part out of the translation string and use placeholder?

Another case:

"%s" in theme.json settings.color.duotone is not a hex or rgb string.

settings.color.duotone wont be translated I guess.

Change History (4)

#1 @rabmalin
7 months ago

  • Version set to 6.3

#2 @Presskopp
7 months ago

there's one more:

Some of the theme.json settings.spacing.spacingScale values are invalid

#3 @SergeyBiryukov
5 months ago

  • Milestone changed from Awaiting Review to 6.5

#4 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57135:

I18N: Move code out of translatable strings in a few error messages.

Follow-up to [54272], [56101].

Props rabmalin, Presskopp.
Fixes #59563.

Note: See TracTickets for help on using tickets.