Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#59575 closed defect (bug) (fixed)

Changes to TT4 for beta 3

Reported by: onemaggie's profile onemaggie Owned by:
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

This PR includes the bugfixes from the GH repo since Beta 2. Most of the changes are bug fixes, improvements to the patterns. Some file renaming for consistency and/or clarity and improving translation strings.

We have an open PR to improve pattern markup formatting for readability but we haven't appropriately tested to include it in this round of changes. I mention it because it has come up in previous reviews, and we are working on it.

Change History (9)

This ticket was mentioned in PR #5440 on WordPress/wordpress-develop by @onemaggie.


2 years ago
#1

  • Keywords has-patch added

This PR includes the bugfixes from the GH repo since Beta 2. Most of the changes are bug fixes, improvements to the patterns. Some file renaming for consistency and/or clarity and improving translation strings.

We have an open PR to improve pattern markup formatting for readability but we haven't appropriately tested to include it in this round of changes. I mention it because it has come up in previous reviews, and we are working on it.

/cc @luminuu @desrosj

Trac ticket: https://core.trac.wordpress.org/ticket/59575

#2 follow-up: @huzaifaalmesbah
2 years ago

I propose that after the beta1 release, contributors who have created issues and pull requests in the TT4 repository should acknowledge and give props to beta3. We can obtain the list of contributors from the CONTRIBUTORS.md file in the TT4 repository.

What is your opinion on this idea, @onemaggie?

#3 in reply to: ↑ 2 ; follow-up: @onemaggie
2 years ago

Replying to huzaifaalmesbah:

I propose that after the beta1 release, contributors who have created issues and pull requests in the TT4 repository should acknowledge and give props to beta3. We can obtain the list of contributors from the CONTRIBUTORS.md file in the TT4 repository.

What is your opinion on this idea, @onemaggie?

I don't know when this usually happens, but I was thinking to give props as closer to release as possible. I would like to make sure that we are not missing anyone, specially from the people who didn't contribute with code but with reviews and discussion

#4 in reply to: ↑ 3 @huzaifaalmesbah
2 years ago

Replying to onemaggie:

I don't know when this usually happens, but I was thinking to give props as closer to release as possible. I would like to make sure that we are not missing anyone, specially from the people who didn't contribute with code but with reviews and discussion

I asked because I wasn't sure which one was the right one. Your response is helpful.

#5 @kebbet
2 years ago

  • Version set to trunk

Please milestone in 6.4. Thanks!

This ticket was mentioned in Slack in #core by karmatosed. View the logs.


2 years ago

#7 @mukesh27
2 years ago

  • Milestone changed from Awaiting Review to 6.4

#8 @karmatosed
2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#9 @kebbet
2 years ago

For reference: [56813] closed this ticket.

Note: See TracTickets for help on using tickets.