PHP error in class-wp-plugins-list-table.php after r56599

[petitphp]

Originally reported in #57791 by TobiasBg

With an incompatible PHP version (just set a plugin's "Requires PHP" header to e.g. 8.4), I'm now getting

Uncaught ArgumentCountError: 2 arguments are required, 1 given in /var/www/html/wordpress/wp-admin/includes/class-wp-plugins-list-table.php:1282

This is caused by the removal of the comma at the end of line 1285 in wp-admin/includes/class-wp-plugins-list-table.php, which was done in https://core.trac.wordpress.org/changeset/56599#file4, when only the HTML code should have been removed. printf() has only one argument then.

[petitphp]

Props to @TobiasBg for reporting the issue.

[TobiasBg]

#59589 was marked as a duplicate.

Combines markup on the same line and restores the comma removed in r56599.

Trac 59590

@sabernhardt There are a lot of unrelated merge commits, can you try rebasing your branch to the latest version of trunk ?

[costdev]

Thanks for creating the ticket @petitphp , for reporting it @TobiasBg and for patching it @sabernhardt.

While this just needs a . replaced with a comma, merging the two strings make sense here.

Self-assigning for commit.

[sabernhardt]

diff from PR 5456

I tried rebasing within GitHub Desktop, but it did not change the PR. If it might help, I uploaded the diff from this PR.

[mukesh27]

Thanks @sabernhardt PR looked good to me too, and it got enough approvals.

[costdev]

In 56824:

Plugins: Fix broken sprintf() call in plugins list table.

In [56599], a sprintf() call was modified which resulted in an insufficient number of arguments.
This caused a Fatal Error when an incompatible plugin notice was displayed.

This fixes the sprintf() call.

Follow-up to [56599].

Props petitphp, TobiasBg, sabernhardt, mukesh27.
Fixes #59590. See #57791.

Committed in r56824