wp_json_encode(): rename parameters for parity with PHP Core

[jrf]

The wp_json_encode() is a wrapper for the PHP native json_encode() function with some extra safety checks.

I propose to rename the $data parameter in the wp_json_encode() function and associated functions to $value and the $options parameter to $flags for parity with the parameter names used in PHP Core (principle of least surprise).

Ref: ​https://www.php.net/manual/en/function.json-encode.php

The wp_json_encode() is a wrapper for the PHP native json_encode() function with some extra safety checks.

This commit renames the $data parameter in the wp_json_encode() function and associated functions to $value and the $options parameter to $flags for parity with the parameter names used in PHP Core (principle of least surprise).

Ref: ​https://www.php.net/manual/en/function.json-encode.php

Trac ticket: https://core.trac.wordpress.org/ticket/59630

[hellofromTonya]

Changing the Version to 4.1.0 which introduced wp_json_encode() with these parameter names.

[jrf]

Replying to hellofromTonya:

Changing the Version to 4.1.0 which introduced wp_json_encode() with these parameter names.

Thanks @hellofromTonya !

On that note: it may well be that the parameter names at the time of introduction were in line with PHP Core.

PHP Core has renamed a lot of parameters to better names in the run up to the release of PHP 8.0 in anticipation of supporting named parameters.
It is not inconceivable that these parameters were renamed in PHP Core as part of that exercise.

[SergeyBiryukov]

In 57130:

General: Rename wp_json_encode() parameters for parity with PHP Core.

wp_json_encode() is a wrapper for the PHP native json_encode() function with some extra safety checks.

This commit renames the $data parameter in the wp_json_encode() function and associated functions to $value, and the $options parameter to $flags for parity with the parameter names used in PHP Core.

Reference: ​PHP Manual: json_encode().

Follow-up to [30055].

Props jrf, hellofromTonya.
Fixes #59630.

Thanks for the PR! Merged in r57130.