Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#59640 closed defect (bug) (fixed)

Changes to Twenty Twenty-Four for RC1

Reported by: onemaggie Owned by: hellofromTonya
Priority: normal Milestone: 6.4
Component: Bundled Theme Version: 6.4
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

This PR includes the bugfixes from the GH repo since Beta 3.

We've reformatted all the patterns for readability as per previous reviews. This makes the diff a little unruly to review, as the patterns also include changes to fix some bugs in the markup and improvements on the string translation functions.

There has been an effort to rename some of the patterns as well, to make them consistent with the content they show and whether they are simple patterns, full-page patterns or patterns meant to replace templates. Let's make sure that when we move this to SVN the old files are removed. I think on the last commit not all the old renamed files were deleted.

Props:

@richtabor
@onemaggie
@luminuu
@Shailu25
@dunhakdis
@shivashankerbhatta
@Dajeema
@enodekciw
@kafleg
@viralsampat
@glendaviesnz
@beafialho
@webmandesign
@huzaifaalmesbah
@GregFuller
@benharri

Change History (3)

This ticket was mentioned in ​PR #5501 on ​WordPress/wordpress-develop by ​@onemaggie.


3 years ago
#1

  • Keywords has-patch added

This PR includes the bugfixes from the GH repo since Beta 3.

We've reformatted all the patterns for readability as ​per previous reviews. This makes the diff a little unruly to review, as the patterns also include changes to fix some bugs in the markup and improvements on the string translation functions.

There has been an effort to rename some of the patterns as well, to make them consistent with the content they show and whether they are simple patterns, full-page patterns or patterns meant to replace templates. Let's make sure that when we move this to SVN the old files are removed. I think on the last commit not all the old renamed files were deleted.

/cc @luminuu

Trac ticket: https://core.trac.wordpress.org/ticket/59640

Props:

@richtabor
@onemaggie
@luminuu
@shailu25
@dunhakdis
@shivashankerbhatta
@dajeema
@enodekciw
@kafleg
@viralsampat
@glendaviesnz
@beafialho
@webmandesign
@huzaifaalmesbah
@gregfuller
@benharri

#2 @hellofromTonya
3 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 6.4
  • Owner set to hellofromTonya
  • Status new → reviewing
  • Version → trunk

As this patch resyncs the TT4 changes into Core for RC1, marking this commit and self-assigning to do the commit.

#3 @hellofromTonya
3 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 56951:

Twenty Twenty-Four: Bugfixes for 6.4 RC1.

Resyncing changes for TT4 into Core.

Changes include:

  • Reformatted all the patterns for readability.
  • Bugfixes in the markup and improvements on the string translation functions.
  • Renaming of some patterns, making them consistent with the content they show and whether they are simple patterns, full-page patterns or patterns meant to replace templates.

Follow-up to [56813], [56764], [56716].

Props richtabor, onemaggie, luminuu, shailu25, dunhakdis, shivashankerbhatta, dajeema, enodekciw, kafleg, viralsampat, glendaviesnz, beafialho, webmandesign, huzaifaalmesbah, gregfuller, benharri.
Fixes #59640.

Note: See TracTickets for help on using tickets.