WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 3 of Ticket #59643


Ignore:
Timestamp:
10/17/2023 10:26:29 AM (2 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #59643

    • Property Milestone changed from Awaiting Review to 6.4

  • Ticket #59643 – Description

    initial v3  
    1 Fixes a bug introduced in #5475.
     1Fixes a bug introduced in #59607.
    22
    3 When applying updates to HTML, one step was left out in #5475 which updated the position of the end of the current tag. This made it possible to create bookmarks with null or earlier end positions than their start position. This in turn broke the Directive Processor in Gutenberg during the backport of changes from Core into Gutenberg.
     3When applying updates to HTML, one step was left out in #59607 which updated the position of the end of the current tag. This made it possible to create bookmarks with null or earlier end positions than their start position. This in turn broke the Directive Processor in Gutenberg during the backport of changes from Core into Gutenberg.
    44
    55In this patch, after applying updates, the HTML document is now scanned fully to the end of the current tag, updating the internal pointer to its end, so that nothing else will be broken or misaligned.\
    … …  
    77---
    88
    9 Given that the bug introduced in #5475 has unknown impact, I strongly urge that we incorporate this patch into 6.4 if it's still possible. The fix should be complete and the reason for this confidence is that it was an obvious-in-hindsight mistake to not find the end of the existing tag when applying updates. Everything except this was called from the change that called the internals directly. Adding the missing piece should close up the erroneous cases.
     9Given that the bug introduced in #59607 has unknown impact, I strongly urge that we incorporate this patch into 6.4 if it's still possible. The fix should be complete and the reason for this confidence is that it was an obvious-in-hindsight mistake to not find the end of the existing tag when applying updates. Everything except this was called from the change that called the internals directly. Adding the missing piece should close up the erroneous cases.