Opened 3 years ago
Last modified 2 months ago
#59648 reviewing task (blessed)
PHPUnit tests: Add/improve @covers annotations
| Reported by: | pbearne | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Future Release |
| Component: | Build/Test Tools | Version: | 4.8 |
| Severity: | normal | Keywords: | has-patch has-unit-tests changes-requested |
| Cc: | Focuses: |
Change History (27)
This ticket was mentioned in PR #5377 on WordPress/wordpress-develop by @pbearne.
3 years ago
#1
- Keywords has-patch has-unit-tests added
This ticket was mentioned in PR #5378 on WordPress/wordpress-develop by @pbearne.
3 years ago
#2
This ticket was mentioned in PR #5379 on WordPress/wordpress-develop by @pbearne.
3 years ago
#3
This ticket was mentioned in PR #5380 on WordPress/wordpress-develop by @pbearne.
3 years ago
#4
This ticket was mentioned in PR #5381 on WordPress/wordpress-develop by @pbearne.
3 years ago
#5
This ticket was mentioned in PR #5382 on WordPress/wordpress-develop by @pbearne.
3 years ago
#6
This ticket was mentioned in PR #5383 on WordPress/wordpress-develop by @pbearne.
3 years ago
#7
This ticket was mentioned in PR #5403 on WordPress/wordpress-develop by @pbearne.
3 years ago
#8
This ticket was mentioned in PR #5402 on WordPress/wordpress-develop by @pbearne.
3 years ago
#9
This ticket was mentioned in PR #5401 on WordPress/wordpress-develop by @pbearne.
3 years ago
#10
This ticket was mentioned in PR #5400 on WordPress/wordpress-develop by @pbearne.
3 years ago
#11
This ticket was mentioned in PR #5392 on WordPress/wordpress-develop by @pbearne.
3 years ago
#12
This ticket was mentioned in PR #5391 on WordPress/wordpress-develop by @pbearne.
3 years ago
#13
This ticket was mentioned in PR #5390 on WordPress/wordpress-develop by @pbearne.
3 years ago
#14
This ticket was mentioned in PR #5389 on WordPress/wordpress-develop by @pbearne.
3 years ago
#15
This ticket was mentioned in PR #5388 on WordPress/wordpress-develop by @pbearne.
3 years ago
#16
This ticket was mentioned in PR #5387 on WordPress/wordpress-develop by @pbearne.
3 years ago
#17
This ticket was mentioned in PR #5384 on WordPress/wordpress-develop by @pbearne.
3 years ago
#18
This ticket was mentioned in PR #5385 on WordPress/wordpress-develop by @pbearne.
3 years ago
#19
This ticket was mentioned in PR #5385 on WordPress/wordpress-develop by @pbearne.
3 years ago
#20
#23
@
2 years ago
- Milestone 6.5 → 6.6
- Owner set to
- Status assigned → reviewing
- Summary PHPUnit tests: Add/improve @covers annotations for WP 6.5 → PHPUnit tests: Add/improve @covers annotations for WP 6.6
My plan: finish the current scope of work (ie the current patch) in March.
But with 6.5 RC1 happening in the next hour or so, moving this to 6.6 and repurposing the ticket to 6.6 cycle.
#24
@
2 years ago
- Keywords changes-requested added
- Milestone 6.6 → Future Release
- Owner removed
There's a big change coming for @covers for the test suite to be compatible with the newest PHPUnit versions. More details will be coming in a follow-up ticket. The tl;dr version: @covers will not be declared at the test method and will be replaced with a test class level attribute (see PHPUnit Code Coverage).
This ticket and its PRs will be closed once a proposal and ticket(s) are opened for the new scope of work.
For now, moving this ticket to Future Release, though I'd suggest no further work or commits happen for it.
This ticket was mentioned in Slack in #core-test by pbearne. View the logs.
2 years ago
#26
@
8 months ago
- Summary PHPUnit tests: Add/improve @covers annotations for WP 6.6 → PHPUnit tests: Add/improve @covers annotations
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
There are tons of uncommitted PRs from the previous ticket, #58851.
Would be good to get these all reviewed & committed one by one.