Changes between Version 1 and Version 2 of Ticket #59673, comment 2
- Timestamp:
- 10/19/2023 04:42:54 PM (19 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #59673, comment 2
v1 v2 21 21 22 22 == TODO 23 === Gutenberg 23 24 - In Gutenberg we need to add the `viewStyle` property to the block.json schema. See GitHub issue https://github.com/WordPress/gutenberg/issues/54491 24 25 - In Gutenberg probably the @wordpress/scripts package needs to be adapted to read `viewStyle` property from block.json to look for assets to build and link. 25 - At the moment there are no e2e/phpunit tests which check if `viewStyle`/`viewScript` get only enqueued in the frontend. Should I add tests for that? And if yes, could someone help me where they have to go? Are those e2e? Are there some other tests testing the rendering of blocks? 26 **What's the process of adding such changes to Gutenberg while changes for the property handling are added here in trac?** 27 === Tests 28 - At the moment there are no e2e/phpunit tests which check if `viewStyle`/`viewScript` get only enqueued in the frontend. Should I add tests for that? And if yes, could someone help me where they have to go? Are those e2e? Are there some other tests testing the rendering of blocks? The unit tests only check if the path registered in wp_scripts is correct. 29 === Core blocks 26 30 - I didn't add any special handling for core blocks, since no core block uses `viewStyle` obviously. But in the future that might be the case. So I think the phpunit tests checking for the correct core styles to be loaded in regard to `should_load_separate_core_block_assets` must be adapted. But I'm not fully sure I understand those. Maybe someone can help me with that. 27 - The checks in GitHub seem to fail but running `composer run lint` locally and manually for the changed files shows no errors in my changes. Need to check that.