Changes between Initial Version and Version 1 of Ticket #59689, comment 8
- Timestamp:
- 10/24/2023 12:21:27 PM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #59689, comment 8
initial v1 1 1 @bplv thanks for your patch. I checked your last patch `59689.4.diff` and it looks good to me because at first, you checked the current page `plugin-install` by using `window.pagenow !== 'plugin-install'` which will prevent to execute any other pages Ajax request. Then you also check is settings data string by using `typeof settings.data === "string"` which will exclude all other types of settings data. 2 2 3 Just to keep consistency, I think you can use `'string'` instead of `"string"` because you used a single quote for every string.3 Just to keep consistency, I think you can use `'string'` instead of `"string"` because the single quote is a more strict sting and everywhere uses a single quote of this file.