WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 6 weeks ago

#59709 closed enhancement (fixed)

test for wp_privacy_exports_url

Reported by: pbearne Owned by: wildworks
Priority: normal Milestone: 7.1
Component: Privacy Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses: tests

Description


Change History (12)

This ticket was mentioned in ​PR #5551 on ​WordPress/wordpress-develop by ​@pbearne.
3 years ago #1

  • Keywords has-patch has-unit-tests added

#2 @desrosj
2 years ago

  • Component Build/Test Tools → Privacy
  • Milestone Awaiting Review → Future Release
  • Type defect (bug) → enhancement

Since this is about adding tests and not a general build or test tooling change, I'm reassigning it to the relevant component.

#3 @desrosj
4 months ago

  • Focuses tests added

Adding the tests focus, which is used to indicate a ticket is solely focused on adding tests.

​@masteradhoc commented on ​PR #5551:
2 months ago #4

Thanks for the work @pbearne and the reviews @mindctrl. i'll milestone this for 7.1 now.

#5 @masteradhoc
2 months ago

  • Milestone Future Release → 7.1

This ticket was mentioned in ​Slack in #core by masteradhoc. ​View the logs.
2 months ago

#7 @adrianduffell
2 months ago

This was discussed in today’s bug scrub. It will be kept in the 7.1 release to be finished this week. Since it adds tests only, I believe It can be safely included in the beta cycle.

This ticket was mentioned in ​Slack in #core by adrianduffell. ​View the logs.
8 weeks ago

​@wildworks commented on ​PR #5551:
6 weeks ago #9

Hi @pbearne, do you have the bandwidth to address the Copilot reviews?

​@pbearne commented on ​PR #5551:
6 weeks ago #10

done

​@masteradhoc commented on ​PR #5551:
6 weeks ago #11

@pbearne can you recheck? the last commit removed the } on line 22.

#12 @wildworks
6 weeks ago

  • Owner set to wildworks
  • Resolution → fixed
  • Status new → closed

In 63028:

Tests: Add unit tests for wp_privacy_exports_url().

This adds coverage for the personal data exports directory URL, verifying both the default location under the uploads directory and that the filter of the same name can override it.

Developed in: ​https://github.com/WordPress/wordpress-develop/pull/5551
Follow-up to [63025].

Props desrosj, masteradhoc, mindctrl, pbearne, wildworks.
Fixes #59709.

Note: See TracTickets for help on using tickets.