#59711 closed defect (bug) (fixed)
Changes to Twenty Twenty-Four for RC2
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.4 | Priority: | normal |
Severity: | normal | Version: | 6.4 |
Component: | Bundled Theme | Keywords: | has-patch commit dev-reviewed |
Focuses: | Cc: |
Description
This PR includes the bugfixes from the GH repo since RC 1.
Some patterns have been updated to fix color issues, a well as some code quality fixes.
Props:
@richtabor
@onemaggie
@luminuu
@kafleg
@swissspidy
@huzaifaalmesbah
@neilorangepeel
@shailu25
@aayusha
@lada7042
@kalmang
@mukesh27
@nilovelez
@yari2u
Change History (13)
This ticket was mentioned in PR #5552 on WordPress/wordpress-develop by @luminuu.
16 months ago
#1
#2
@
16 months ago
- Owner set to desrosj
- Resolution set to fixed
- Status changed from new to closed
In 56999:
#3
@
16 months ago
- Keywords commit dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for second committer review and backport.
#5
@
16 months ago
- Keywords dev-reviewed added; dev-feedback removed
Looks good to backport to the 6.4 branch. Thanks @desrosj!
#6
@
16 months ago
[56999] is missing the pattern file rename
from:
src/wp-content/themes/twentytwentyfour/patterns/template-search-writer.php
to:
src/wp-content/themes/twentytwentyfour/patterns/template-search-blogging.php
Maybe a follow-up commit and then backport both in one commit to 6.4.
16 months ago
#9
@Yari2u @KalmanG @aayushastha I was unable to locate your WordPress.org profile. A WordPress.org profile is required to receive proper credit for contributions on the About screen within the WordPress dashboard for a given release.
Could you please share your .org profile if you already have one that I missed, or follow the instructions in this blog post to create and connect a .org account.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
16 months ago
#11
@
16 months ago
Weird that svn mv
didn't bring over the move meta in [57003]. But as @desrosj noted in Make/Core slack, it's okay given that the theme has not yet been released.
This didn't quite track the move like I thought it would. But I think it's fine since the theme hasn't been released yet and I mention in the commit message that it renames a file.
Both [56999] and [57003] LGTM for backport to the 6.4 branch.
16 months ago
#13
@desrosj We have them listed in our CONTRIBUTORS.md file with both Github and w.org profiles: https://github.com/WordPress/twentytwentyfour/blob/trunk/CONTRIBUTORS.md
GitHub Username | WordPress.org Username |
---|---|
@aayushastha | @aayusha |
@KalmanG | @kalmang |
@Yari2u | @yari2u |
This PR includes the bugfixes from the GH repo since RC 1.
Some patterns have been updated to fix color issues, a well as some code quality fixes.
/cc @MaggieCabrera
Trac ticket: https://core.trac.wordpress.org/ticket/59711
Props:
@richtabor
@MaggieCabrera
@luminuu
@kafleg
@swissspidy
@huzaifaalmesbah
@neilorangepeel
@shail-mehta
@aayushastha
@lada7042
@KalmanG
@mukeshpanchal27
@nilovelez
@Yari2u