Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#59711 closed defect (bug) (fixed)

Changes to Twenty Twenty-Four for RC2

Reported by: luminuu's profile luminuu Owned by: desrosj's profile desrosj
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: Bundled Theme Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description

This PR includes the bugfixes from the GH repo since RC 1.

Some patterns have been updated to fix color issues, a well as some code quality fixes.

Props:
@richtabor
@onemaggie
@luminuu
@kafleg
@swissspidy
@huzaifaalmesbah
@neilorangepeel
@shailu25
@aayusha
@lada7042
@kalmang
@mukesh27
@nilovelez
@yari2u

Change History (13)

This ticket was mentioned in PR #5552 on WordPress/wordpress-develop by @luminuu.


6 months ago
#1

This PR includes the bugfixes from the GH repo since RC 1.

Some patterns have been updated to fix color issues, a well as some code quality fixes.

/cc @MaggieCabrera

Trac ticket: https://core.trac.wordpress.org/ticket/59711

Props:
@richtabor
@MaggieCabrera
@luminuu
@kafleg
@swissspidy
@huzaifaalmesbah
@neilorangepeel
@shail-mehta
@aayushastha
@lada7042
@KalmanG
@mukeshpanchal27
@nilovelez
@Yari2u

#2 @desrosj
6 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 56999:

Twenty Twenty-Four: Bug fixes for 6.4 RC2.

This update includes updates to patterns to correct color issues and some code quality fixes.

Follow-up to [56951], [56813], [56764], [56716].

Props luminuu, richtabor, onemaggie, kafleg, swissspidy, huzaifaalmesbah, neilorangepeel, shailu25, lada7042, mukesh27, nilovelez, jorbin.
Fixes #59711.

#3 @desrosj
6 months ago

  • Keywords commit dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for second committer review and backport.

#4 @desrosj
6 months ago

  • Milestone changed from Awaiting Review to 6.4

#5 @davidbaumwald
6 months ago

  • Keywords dev-reviewed added; dev-feedback removed

Looks good to backport to the 6.4 branch. Thanks @desrosj!

#6 @hellofromTonya
6 months ago

[56999] is missing the pattern file rename

from:

src/wp-content/themes/twentytwentyfour/patterns/template-search-writer.php

to:

src/wp-content/themes/twentytwentyfour/patterns/template-search-blogging.php

Maybe a follow-up commit and then backport both in one commit to 6.4.

#7 @desrosj
6 months ago

In 57003:

Twenty Twenty-Four: Include file renaming for RC2.

This includes a file renaming that was missed in [56999].

Follow-up to [56999], [56951], [56813], [56764], [56716].

Props hellofromTonya, huzaifaalmesbah.
See #59711.

@desrosj commented on PR #5552:


6 months ago
#9

@Yari2u @KalmanG @aayushastha I was unable to locate your WordPress.org profile. A WordPress.org profile is required to receive proper credit for contributions on the About screen within the WordPress dashboard for a given release.

Could you please share your .org profile if you already have one that I missed, or follow the instructions in this blog post to create and connect a .org account.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


6 months ago

#11 @hellofromTonya
6 months ago

Weird that svn mv didn't bring over the move meta in [57003]. But as @desrosj noted in Make/Core slack, it's okay given that the theme has not yet been released.

This didn't quite track the move like I thought it would. But I think it's fine since the theme hasn't been released yet and I mention in the commit message that it renames a file.

Both [56999] and [57003] LGTM for backport to the 6.4 branch.

#12 @desrosj
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57005:

Twenty Twenty-Four: Bug fixes for 6.4 RC2.

This update includes updates to patterns to correct color issues and some code quality fixes.

Follow-up to [56951], [56813], [56764], [56716].

Props luminuu, richtabor, onemaggie, kafleg, swissspidy, huzaifaalmesbah, neilorangepeel, shailu25, lada7042, mukesh27, nilovelez, jorbin.
Merges [56999] and [57003] to the 6.4 branch.
Fixes #59711.

@luminuu commented on PR #5552:


6 months ago
#13

@desrosj We have them listed in our CONTRIBUTORS.md file with both Github and w.org profiles: https://github.com/WordPress/twentytwentyfour/blob/trunk/CONTRIBUTORS.md

GitHub Username WordPress.org Username
@aayushastha @aayusha
@KalmanG @kalmang
@Yari2u @yari2u
Note: See TracTickets for help on using tickets.