Make WordPress Core

Opened 8 months ago

Last modified 8 months ago

#59728 assigned enhancement

Build/Test Tools: Expose error message upon Gutenberg plugin activation failure.

Reported by: bernhard-reiter's profile Bernhard Reiter Owned by: bernhard-reiter's profile Bernhard Reiter
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

In [54913], an end-to-end test was added to ensure that installing and activating the Gutenberg plugin didn't cause any fatal errors. (For the rationale behind this, refer to #57197.) Through its integration with GitHub's CI, this allowed catching code that would lead to fatals (e.g. duplicated function names) before it was committed.

The downside of doing this via an e2e test is that the error message shown in CI is fairly generic and thus somewhat easy to miss and/or ignore, even though WordPress does report the specific error that would cause an error when attempting to activate Gutenberg.

Thus, it seems preferable to implement the test differently to expose WordPress' error message. One way to go about this would be to add a separate GH workflow (yml file) and to use WP CLI to install and activate GB.

Change History (4)

#1 @Bernhard Reiter
8 months ago

  • Owner set to Bernhard Reiter
  • Status changed from new to assigned

This ticket was mentioned in PR #5570 on WordPress/wordpress-develop by @Bernhard Reiter.


8 months ago
#2

  • Keywords has-patch added

Description TBD

Trac ticket: https://core.trac.wordpress.org/ticket/59728

@Bernhard Reiter commented on PR #5570:


8 months ago
#3

FYI @desrosj

@desrosj commented on PR #5570:


8 months ago
#4

Adding myself as a reviewer so that it's in my list to come back to!

Note: See TracTickets for help on using tickets.