Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#5973 closed defect (bug) (fixed)

Admin should use semantic classes

Reported by: filosofo's profile filosofo Owned by: iammattthomas's profile iammattthomas
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: Administration Keywords: css semantic-markup has-patch
Focuses: Cc:

Description

As explained here, semantic class names should reflect function, not a particular style. So for example "niceblue" isn't such a great class name, as a differently-styled admin page might not even use blue there.

WordPress advertises itself as a "semantic personal publishing platform", and there is at least one ''A List Apart'' article supporting semantic class names (A List Apart is of course published by Happy Cog, the designers of the new WP admin theme), so this should be a part of the new WordPress design.

Attachments (2)

remove_niceblue_class.diff (15.1 KB) - added by filosofo 16 years ago.
form-table.diff (15.1 KB) - added by iammattthomas 16 years ago.
Patches #5973 with .form-table class replacing .niceblue

Download all attachments as: .zip

Change History (8)

#1 @filosofo
16 years ago

Please let's fix this before the 2.5 release, as once it's out there, we plugin authors will be saddled with it for a long time. There's already someone telling plugin authors to use "niceblue" in preparation for 2.5.

#2 @ryan
16 years ago

  • Owner changed from anonymous to iammattthomas

I pinged MT for some HC feedback. Changing it is a perl script away once a new name is decided upon.

#3 @ryan
16 years ago

Or, one patch -p0 away since you attached a diff. :-)

#4 @iammattthomas
16 years ago

I agree completely; I'm going to suggest the name .form-table for the sake of specificity.

@iammattthomas
16 years ago

Patches #5973 with .form-table class replacing .niceblue

#5 @filosofo
16 years ago

Perfect! Thanks.

#6 @ryan
16 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7000]) Change niceblue class name to form-table. Props filosofo and mt. fixes #5973

Note: See TracTickets for help on using tickets.