Block Hooks: Allow child insertion into Navigation block

[Bernhard Reiter]

One of the original use cases for Block Hooks was inserting a Login/out block into (i.e. as the last child of) the Navigation block. Ironically, that isn't currently possible, due to the nature of the Navigation block and how it conditionally renders its child blocks or falls back to existing menus.

It's possible to work around this limitation by inserting a hooked block after the Navigation block, which is something we've e.g. done with the Mini Cart example that we've used in some of our documentation, but that's still suboptimal and plainly untenable for a text link such as the Login/out block.

We should try to make this work for 6.5.

[Bernhard Reiter]

cc/ @gziolo @get_dave @ndiego

[Bernhard Reiter]

@tomjcafferkey is working on a fix in the GB repo: ​https://github.com/WordPress/gutenberg/pull/57754.

Follow-up to ​https://github.com/WordPress/gutenberg/pull/57754.
Commit to Core once packages have been synced from Gutenberg to include ​https://github.com/WordPress/gutenberg/pull/57754.

See https://core.trac.wordpress.org/ticket/59743.

cc/ Editor Tech Leads @getdave @youknowriad

[Bernhard Reiter]

Setting to resolved as resolved-upstream, as this is tackled by ​https://github.com/WordPress/gutenberg/pull/57754, which has now been merged; the code changes will be carried over by an npm package sync.

The only thing left to do after that has happened will be to update some PHPDoc: ​https://github.com/WordPress/wordpress-develop/pull/5946

Is this ready to be committed, what's left here?

Is this ready to be committed, what's left here?

Maybe let's wait for @ockham to confirm. There might be now a bit different approach used.

Should be ready to go! Thanks all 😊

[youknowriad]

In 57550:

Editor: Update PHPDoc for block bindings's context arg.

The context argument passed to the hooked_block_types filter can also be a Post object
in the case of the navigation block.
This adapts the PHPDoc accordingly.

Props bernhard-reiter, gziolo.
See #59743.

Commit https://core.trac.wordpress.org/changeset/57550