remove not needed function call in wp_post_preview_js

[pbearne]

In this function, we created some JS with "<script>" tags and removed them with a call to wp_remove_surrounding_empty_script_tags()

So this patch removes the tags and function call

see ticket #59775 for tests for this function/change

[mukesh27]

Thanks @pbearne for the ticket and PR!

@westonruter added the wp_remove_surrounding_empty_script_tags function in [56748] / #58664. I'd appreciate getting his thoughts on this matter.

[pbearne]

I agree the change made by @westonruter was an improvement of what was there before, and having the <script> tag makes clear that you are looking at a block JS code.

But in all the cases, you could not include the <script> tag and get the same output with one less call.

[westonruter]

The <script> tag is needed for the sake of IDEs to do static analysis at development time. Since this JavaScript code is not run through any linters at build time, having every bit of development support at code time is important. The removal of wp_remove_surrounding_empty_script_tags() should only happen once the <script> wrappers aren't needed anymore, which would be done as part of #59444. Once the minimum version of PHP is bumped to 7.3, then HEREDOC strings can be used instead of the <script> wrappers and wp_remove_surrounding_empty_script_tags() can be removed.

[pbearne]

@westonruter, thanks for the feedback
I agree on to closing this ticket and will try to remember to update when we bump the PHP version.