WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Last modified 9 months ago

#59781 new enhancement

Add tests for wp_delete_file_from_directory

Reported by: pbearne's profile pbearne Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Filesystem API Keywords: has-patch has-unit-tests
Focuses: tests Cc:

Description (last modified by pbearne)

While testing this I found you could pass stream URL to it but all failed without error apart from ​file:// so changed the code to return false for others

I am not sure why we allow Streamed to be used but that is what the code allowed :-)

Change History (4)

#1 @pbearne
2 years ago

  • Description modified (diff)

This ticket was mentioned in ​PR #5603 on ​WordPress/wordpress-develop by ​@pbearne.
2 years ago #2

  • Keywords has-patch has-unit-tests added

… stream URL failing

#3 @desrosj
13 months ago

  • Component changed from Build/Test Tools to Filesystem API
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from test_wp_delete_file_from_directory to Add tests for wp_delete_file_from_directory
  • Type changed from defect (bug) to enhancement

Since this is about adding tests and not a general build or test tooling change, I'm reassigning it to the relevant component.

#4 @desrosj
9 months ago

  • Focuses tests added
Note: See TracTickets for help on using tickets.