WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Last modified 7 weeks ago

#59781 new enhancement

Add tests for wp_delete_file_from_directory

Reported by: pbearne Owned by:
Priority: normal Milestone: Future Release
Component: Filesystem API Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses: tests

Description (last modified by pbearne)

While testing this I found you could pass stream URL to it but all failed without error apart from ​file:// so changed the code to return false for others

I am not sure why we allow Streamed to be used but that is what the code allowed :-)

Change History (5)

#1 @pbearne
3 years ago

  • Description modified (diff)

This ticket was mentioned in ​PR #5603 on ​WordPress/wordpress-develop by ​@pbearne.
3 years ago #2

  • Keywords has-patch has-unit-tests added

… stream URL failing

#3 @desrosj
2 years ago

  • Component Build/Test Tools → Filesystem API
  • Milestone Awaiting Review → Future Release
  • Summary test_wp_delete_file_from_directory → Add tests for wp_delete_file_from_directory
  • Type defect (bug) → enhancement

Since this is about adding tests and not a general build or test tooling change, I'm reassigning it to the relevant component.

#4 @desrosj
19 months ago

  • Focuses tests added

​@mindctrl commented on ​PR #5603:
7 weeks ago #5

@pbearne I think this is good to go once the spelling nits are fixed. Could you bring it up to date with trunk and I'll give it another final whirl?

Note: See TracTickets for help on using tickets.