#59800 closed defect (bug) (duplicate)
Twenty Fourteen: Pullquote block does not support custom font size
Reported by: | nidhidhandhukiya | Owned by: | karmatosed |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 5.9 |
Component: | Bundled Theme | Keywords: | |
Focuses: | css | Cc: |
Description
Steps to reproduce the issue :-
- Activate Twenty Fourteen theme.
- Choose Pullquote block.
- Change font size from the settings.
You can able to see both the side there is no change in font size.
I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/rsTnRLQstYrhDc6lXT1z
Attachments (3)
Change History (18)
#5
@
9 months ago
- Owner set to karmatosed
- Resolution set to fixed
- Status changed from new to closed
In 57989:
#6
@
9 months ago
- Focuses css added
- Keywords needs-patch added; commit removed
- Milestone changed from 6.5.3 to 6.6
- Summary changed from Twenty Fourteen : Pullquote block having issue with font size. to Twenty Fourteen: Pullquote block does not support custom font size
[57989] changes the default font size of Pullquote blocks, Quote blocks, and blockquote
elements in the Classic block/Classic Editor from 19px.
- Pullquote blocks increased to 24px
- Quote blocks and Classic quotes decreased to 16px
This is also not urgent enough to create a new version of the theme before July.
#7
@
9 months ago
I made a set of blocks to show the default font size plus the Large preset and a custom font size.
#9
@
9 months ago
- Keywords has-patch added; needs-patch removed
Updated Changes as per mentioned above.
- Added Default Font size Same as before(font-size:19px) for Blockquote & Pullquote & Quote blocks
- Inherited font size when custom font size is selected in editor so it will show selected font size in backend & frontend.
@
9 months ago
restores default 19px for blockquote
elements and inherits custom font sizes in Pullquote blocks
#10
@
9 months ago
- Version changed from 6.3.2 to 5.9
Thanks for creating the patch! I did not find a need to inherit a font size for the Quote block or the p
and cite
elements with Twenty Fourteen, though.
- restores the default 19px for any
blockquote
element - uses low specificity for front end
- uses more specific selectors to override
.editor-styles-wrapper blockquote
in non-framed editor - does not change sizes for the Quote block
#11
@
9 months ago
Patch Report - https://core.trac.wordpress.org/attachment/ticket/59800/59800.1.diff
Environment
WordPress - 6.5
OS - Windows
Browser - Firefox
Theme: Twenty Fourteen
PHP - 8.1.23
Before
- Backend - https://prnt.sc/uUYW5RuSTAcE
- Frontend - https://prnt.sc/JZcB85eUFc6i
After Patch
- Backend - https://prnt.sc/a5zmSRbpSK3p
- Frontend - https://prnt.sc/sNc72fd477yC
Result : Pullquote block custom font size working fine
#12
@
9 months ago
- Keywords close added; has-patch removed
Closing this one to focus on: https://core.trac.wordpress.org/ticket/61034
@nidhidhandhukiya thank you for the patch. I can see this does solve it. There is a consideration perhaps of how to refine the jumping that happens around of the visual as it goes up and down in size. My concern though in doing that would be making a design decision - so for now let's avoid that and commit this. Thank you for working on this.