Make WordPress Core

Opened 7 months ago

Last modified 3 days ago

#59802 new defect (bug)

Twenty Fifteen: Quote block citation text color does not change with block setting

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.3.2
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: css Cc:

Description

Hello Team,

I have worked on the "Quote" block and found that its "Add Citation" text color is not changed when we try to set it from the block setting.

Here, I have attached its video.

Issue: https://share.cleanshot.com/c5VnwHz1Qt34NPXcHw9f

Thanks,

Attachments (2)

59802.patch (988 bytes) - added by viralsampat 7 months ago.
I have checked above mentioned issue and resolved it. Here, I have added my patch.
59802.diff (1.5 KB) - added by shailu25 3 weeks ago.
Patch Updated.

Download all attachments as: .zip

Change History (6)

@viralsampat
7 months ago

I have checked above mentioned issue and resolved it. Here, I have added my patch.

#1 @poena
6 weeks ago

  • Component changed from Themes to Bundled Theme

#2 @sabernhardt
3 weeks ago

  • Keywords changes-requested added; needs-patch dev-feedback removed
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from The quote block Add Citation text color issue into the theme Twenty Fifteen to Twenty Fifteen: Quote block citation text color does not change with block setting

Twenty Fifteen clearly defines the citation color as #333, and it needs to remain the default. The citation can inherit the color from the block only when that color is changed.

@shailu25
3 weeks ago

Patch Updated.

#3 @shailu25
3 weeks ago

  • Keywords has-patch added; changes-requested removed

Updated Patch as per suggested in above comment

  • Added color:inherit when color is selected/changed
  • If No Color is selected in backend then it will show default color #333 for Citation text.

#4 @karmatosed
3 days ago

  • Keywords needs-testing added
  • Milestone changed from Future Release to 6.6

Thank you for updating the patch. Let's now get some testing and see about getting this ready for commit. I am going to cautiously move this into the next release in preparation for that.

Note: See TracTickets for help on using tickets.