Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 3 years ago

Closed 3 years ago

#59812 closed defect (bug) (fixed)

Twenty Twenty-Four: fixed contrast issues, improved documentations, general polishing before release

Reported by:	onemaggie	Owned by:	hellofromTonya
Priority:	normal	Milestone:	6.4
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	has-patch commit dev-reviewed
Cc:		Focuses:

Description (last modified by sabernhardt)

This PR includes the last fixes to the theme before the release:

Addresses some issues with contrast on some of the theme variations, we ended up removing a color that is no longer used from the theme and variations.
Fixes an issue with a pattern that was using the wrong unit type for the min-height.
Moves wp_enqueue_block_style call to its own function for clarity.
Updates the link to the docs on the changelog

Props:

onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena

Change History (14)

This ticket was mentioned in PR #5623 on WordPress/wordpress-develop by @onemaggie.

3 years ago #1

Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/59812

This PR includes the last fixes to the theme before the release:

https://github.com/WordPress/twentytwentyfour/pull/723
https://github.com/WordPress/twentytwentyfour/pull/718
https://github.com/WordPress/twentytwentyfour/pull/719
https://github.com/WordPress/twentytwentyfour/pull/720
https://github.com/WordPress/twentytwentyfour/pull/722

Addresses some issues with contrast on some of the theme variations, we ended up removing a color that is no longer used from the theme and variations.
Fixes an issue with a pattern that was using the wrong unit type for the min-height.
Moves wp_enqueue_block_style call to its own function for clarity.
Updates the link to the docs on the changelog

Props:

onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena

#2 @sabernhardt
3 years ago

Description modified (diff)
Summary Twenty twenty-four: fixed contrast issues, improved documentations, general polishing before release → Twenty Twenty-Four: fixed contrast issues, improved documentations, general polishing before release

#3 @sabernhardt
3 years ago

Milestone Awaiting Review → 6.4

#4 @rajinsharwar
3 years ago

Tested out the patch.

It resolves the issue with min-height with the pattern shown in PR 720. 🟢
Solves the colour issue mentioned in PR 722 🟢

#5 @hellofromTonya
3 years ago

Owner set to hellofromTonya
Status new → reviewing

Reviewing for commit.

@hellofromTonya commented on PR #5623:

3 years ago #6

Confirmed changes are ported to this PR ✅

Next step: Test the PR to ensure the theme loads and renders without errors.

#7 @hellofromTonya
3 years ago

Keywords commit added

Patch:

The patch is approved and ready for commit:

Includes the recent changes since RC3 ✅
Renders properly without errors ✅
Has a test report to confirm the changes work - see comment:4 ✅

Preparing the commit to trunk now.

#8 @hellofromTonya
3 years ago

Resolution → fixed
Status reviewing → closed

Twenty Twenty-Four: Bugfixes and refinement for 6.4 RC4.

This update includes the following changes:

Remove custom CSS for links.
Fix the link to the theme's docs.
Separate outline css to its own function - which introduces twentytwentyfour_block_stylesheets() for enqueuing custom block stylesheets.
Fix height of newsletter landing pattern.
Resolve border colors in variations.

Follow up to [57036], [56999], [56951], [56813], [56764], [56716].

Props onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena, rajinsharwar.
Fixes #59812.

#9 @hellofromTonya
3 years ago

Keywords dev-feedback added

Reopening for 2nd committer review / sign-off to backport [57067] to the 6.4 branch.

#10 @hellofromTonya
3 years ago

Resolution fixed
Status closed → reopened

@hellofromTonya commented on PR #5623:

3 years ago #11

Committed to trunk via https://core.trac.wordpress.org/changeset/57067.

#12 @desrosj
3 years ago

Keywords dev-reviewed added; dev-feedback removed

[57067] is good for backport!

#13 @hellofromTonya
3 years ago

Thank you @desrosj :) Backporting now.

#14 @hellofromTonya
3 years ago

Resolution → fixed
Status reopened → closed

Twenty Twenty-Four: Bugfixes and refinement for 6.4 RC4.

This update includes the following changes:

Remove custom CSS for links.
Fix the link to the theme's docs.
Separate outline css to its own function - which introduces twentytwentyfour_block_stylesheets() for enqueuing custom block stylesheets.
Fix height of newsletter landing pattern.
Resolve border colors in variations.

Follow up to [57036], [56999], [56951], [56813], [56764], [56716].

Reviewed by desrosj.
Merges [57067] to the 6.4 branch.

Props onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena, rajinsharwar.
Fixes #59812.

Note: See TracTickets for help on using tickets.

Download in other formats: