Opened 16 months ago
Closed 16 months ago
#59812 closed defect (bug) (fixed)
Twenty Twenty-Four: fixed contrast issues, improved documentations, general polishing before release
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch commit dev-reviewed |
Focuses: | Cc: |
Description (last modified by )
This PR includes the last fixes to the theme before the release:
Addresses some issues with contrast on some of the theme variations, we ended up removing a color that is no longer used from the theme and variations.
Fixes an issue with a pattern that was using the wrong unit type for the min-height
.
Moves wp_enqueue_block_style
call to its own function for clarity.
Updates the link to the docs on the changelog
Props:
onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena
Change History (14)
This ticket was mentioned in PR #5623 on WordPress/wordpress-develop by @onemaggie.
16 months ago
#1
- Keywords has-patch added
#2
@
16 months ago
- Description modified (diff)
- Summary changed from Twenty twenty-four: fixed contrast issues, improved documentations, general polishing before release to Twenty Twenty-Four: fixed contrast issues, improved documentations, general polishing before release
#4
@
16 months ago
Tested out the patch.
- It resolves the issue with min-height with the pattern shown in PR 720. 🟢
- Solves the colour issue mentioned in PR 722 🟢
#5
@
16 months ago
- Owner set to hellofromTonya
- Status changed from new to reviewing
Reviewing for commit.
@hellofromTonya commented on PR #5623:
16 months ago
#6
Confirmed changes are ported to this PR ✅
Next step: Test the PR to ensure the theme loads and renders without errors.
#7
@
16 months ago
- Keywords commit added
Patch:
The patch is approved and ready for commit:
- Includes the recent changes since RC3 ✅
- Renders properly without errors ✅
- Has a test report to confirm the changes work - see comment:4 ✅
Preparing the commit to trunk
now.
#9
@
16 months ago
- Keywords dev-feedback added
Reopening for 2nd committer review / sign-off to backport [57067] to the 6.4 branch.
@hellofromTonya commented on PR #5623:
16 months ago
#11
Committed to trunk
via https://core.trac.wordpress.org/changeset/57067.
Trac ticket: https://core.trac.wordpress.org/ticket/59812
This PR includes the last fixes to the theme before the release:
https://github.com/WordPress/twentytwentyfour/pull/723
https://github.com/WordPress/twentytwentyfour/pull/718
https://github.com/WordPress/twentytwentyfour/pull/719
https://github.com/WordPress/twentytwentyfour/pull/720
https://github.com/WordPress/twentytwentyfour/pull/722
Addresses some issues with contrast on some of the theme variations, we ended up removing a color that is no longer used from the theme and variations.
Fixes an issue with a pattern that was using the wrong unit type for the min-height.
Moves wp_enqueue_block_style call to its own function for clarity.
Updates the link to the docs on the changelog
Props:
onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena