Opened 15 months ago
Closed 11 months ago
#59816 closed task (blessed) (fixed)
Bump default theme versions for WordPress 6.5
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch fixed-major commit dev-reviewed |
Focuses: | Cc: |
Attachments (5)
Change History (31)
#2
@
13 months ago
- Keywords has-patch added; needs-patch removed
I’ve bumped all the theme versions for WordPress 6.5.
Below is lists,
- Twenty Ten: 4.1
- Twenty Eleven: 4.6
- Twenty Twelve: 4.2
- Twenty Thirteen: 4.1
- Twenty Fourteen: 3.9
- Twenty Fifteen: 3.7
- Twenty Sixteen: 3.2
- Twenty Seventeen: 3.5
- Twenty Nineteen: 2.8
- Twenty Twenty: 2.5
- Twenty Twenty-One: 2.1
- Twenty Twenty-Two: 1.7
- Twenty Twenty-Three: 1.4
Please check the attached https://core.trac.wordpress.org/attachment/ticket/59816/59816.diff file.
#3
@
12 months ago
@kushang78
I notice you change some docs @since version
and also Twenty Twenty-Four theme change Requires at least: 6.4
they do not need to be changed.
And maybe you forgot to update the theme version of Twenty Twenty-Four.
#4
@
12 months ago
@huzaifaalmesbah , Thanks for your feedback
In attached latest patch file, I’ve fixed those things that you have mentioned.
Note: Please consider 59816.19.02.2024.diff
patch file as latest.
Thanks!
#5
@
12 months ago
Thanks @kushang78 for the patch.
There are still Remaining Version changes in below files:
- src/wp-content/themes/twentynineteen/package-lock.json
- src/wp-content/themes/twentynineteen/package.json
- src/wp-content/themes/twentyseventeen/functions.php
- src/wp-content/themes/twentytwenty/package-lock.json
- src/wp-content/themes/twentytwenty/package.json
- src/wp-content/themes/twentytwentyone/assets/css/ie.css
- src/wp-content/themes/twentytwentyone/assets/sass/01-settings/file-header.scss
- src/wp-content/themes/twentytwentyone/package-lock.json
- src/wp-content/themes/twentytwentyone/package.json
- src/wp-content/themes/twentytwentyone/style-rtl.css
- src/wp-content/themes/twentytwentyfour/style.css
- src/wp-content/themes/twentytwentyfour/readme.txt
#6
@
12 months ago
@shailu25 , Thanks for your feedback
In attached latest patch file, I’ve fixed those things in all the files that you have mentioned.
Thanks!
#7
@
12 months ago
Hi @kushang78
Thanks for Update.
One change is still remaining in twentytwentyfour theme.
In readme.txt file stable tag also need to be changed.
#8
@
12 months ago
Can we add the updated changelog links to the readme files as part of this update?
Update all the new and existing changelog codex links to point to the new articles.
Example:
https://codex.wordpress.org/Twenty_Fifteen_Theme_Changelog#Version_3.7
Would be https://wordpress.org/documentation/article/twenty-fifteen-changelog/#Version_3.7
More information: https://github.com/WordPress/Documentation-Issue-Tracker/issues/1442
https://wordpress.org/documentation/article/twenty-ten-changelog/
https://wordpress.org/documentation/article/twenty-eleven-changelog/
https://wordpress.org/documentation/article/twenty-twelve-changelog/
https://wordpress.org/documentation/article/twenty-thirteen-changelog/
https://wordpress.org/documentation/article/twenty-fourteen-changelog/
https://wordpress.org/documentation/article/twenty-fifteen-changelog/
https://wordpress.org/documentation/article/twenty-sixteen-changelog/
https://wordpress.org/documentation/article/twenty-seventeen-changelog/
https://wordpress.org/documentation/article/twenty-nineteen-changelog/
https://wordpress.org/documentation/article/twenty-twenty-changelog/
https://wordpress.org/documentation/article/twenty-twenty-one-changelog/
https://wordpress.org/documentation/article/twenty-twenty-two-changelog/
https://wordpress.org/documentation/article/twenty-twenty-three-changelog/
https://wordpress.org/documentation/article/twenty-twenty-four-changelog/
#9
@
12 months ago
I’ve made all the requested changes for this ticket but during uploading the latest patch file, I got “Maximum number of external links per post exceeded”
error.
So, Can you please suggest what should I do here?
Please check the attached screenshot of the error.
Thanks!
#10
follow-up:
↓ 17
@
11 months ago
@kushang78 I am not sure how to solve that problem, can you describe the steps you took? - I mean what you were doing when the error occurred.
This ticket was mentioned in Slack in #meta by poena. View the logs.
11 months ago
#12
follow-up:
↓ 16
@
11 months ago
@kushang78 Are you available to split your patch into multiple smaller .diff files and try to upload them again?
@mukesh27 @desrosj At the latest, at what time in a release does this step need to be completed? Considering RC1 is in a few hours.
#13
@
11 months ago
Smaller .diff files might still have too many links with all of the changelog updates. I'm working on a pull request.
A few blocks stylesheets need newer version numbers too.
- Twenty Fifteen
blocks.css
:20240210
- Twenty Fifteen
editor-blocks.css
:20240117
- Twenty Sixteen
blocks.css
:20240117
- Twenty Sixteen
editor-blocks.css
:20240209
This ticket can go into the RC phase, as similar tickets did for at least the last two major releases (6.4's theme updates were even committed and backported within two hours of the dry run). Of course, completing it before branching would be nice.
This ticket was mentioned in PR #6224 on WordPress/wordpress-develop by @sabernhardt.
11 months ago
#14
Twenty Ten: 4.1
Twenty Eleven: 4.6
Twenty Twelve: 4.2
Twenty Thirteen: 4.1
Twenty Fourteen: 3.9
Twenty Fifteen: 3.7
Twenty Sixteen: 3.2
Twenty Seventeen: 3.6
Twenty Nineteen: 2.8
Twenty Twenty: 2.6
Twenty Twenty-One: 2.2
Twenty Twenty-Two: 1.7
Twenty Twenty-Three: 1.4
Twenty Twenty-Four: 1.1
All of these changelog links point to HelpHub now.
Trac ticket: https://core.trac.wordpress.org/ticket/59816
#15
@
11 months ago
Agreed that this can be made during RC. This is more of a procedural change that should only be bumping the versions for each theme.
Ideally we're not making it between the last RC and final release, though.
#16
in reply to:
↑ 12
@
11 months ago
Replying to poena:
@kushang78 Are you available to split your patch into multiple smaller .diff files and try to upload them again?
@mukesh27 @desrosj At the latest, at what time in a release does this step need to be completed? Considering RC1 is in a few hours.
@poena, I Already splitted the patch into multiple smaller .diff (Approx 9-10 .diff files). And then I tried to upload here, Not working facing the same error.
#17
in reply to:
↑ 10
@
11 months ago
Replying to poena:
@kushang78 I am not sure how to solve that problem, can you describe the steps you took? - I mean what you were doing when the error occurred.
The Steps:
@poena , According to the Comment #comment:8, I've just updated all the changelog codex links url to the latest one for all themes and generated the latest patch. That's it.
I'm agreed with the #comment:13. The Pull request might be the option to make this links related change.
#18
@
11 months ago
PR 6224 looks correct to me,
- The versions are correct.
- The new dates for the linked or enqueued CSS files match the release date or the latest changes to the files.
- The links in the readme are updated.
Added patch for this ticket.