Make WordPress Core

Opened 7 months ago

Closed 2 months ago

#59816 closed task (blessed) (fixed)

Bump default theme versions for WordPress 6.5

Reported by: mukesh27's profile mukesh27 Owned by: desrosj's profile desrosj
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch fixed-major commit dev-reviewed
Focuses: Cc:

Description (last modified by mukesh27)

All bundled themes from 2010 to 2024 will need a version bump for the 6.5 release.

Previously:
#58832 - 6.4
#57857 - 6.3
#57689 - 6.2
#56450 - 6.1
#55754 - 6.0
#54783 - 5.9
#53277 - 5.8
#52704 - 5.7
#51919 - 5.6
#50889 - 5.5
#49743 - 5.4

Attachments (5)

59816.diff (33.3 KB) - added by kushang78 4 months ago.
Added patch for this ticket.
59816.2.diff (33.3 KB) - added by kushang78 3 months ago.
Added patch for this ticket.
59816.19.02.2024.diff (36.6 KB) - added by kushang78 3 months ago.
Added latest patch for this ticket.
59816.20.02.2024.diff (44.0 KB) - added by kushang78 3 months ago.
Added latest patch for this ticket.
image.png (25.4 KB) - added by kushang78 3 months ago.

Download all attachments as: .zip

Change History (31)

#1 @mukesh27
7 months ago

  • Description modified (diff)

@kushang78
4 months ago

Added patch for this ticket.

#2 @kushang78
4 months ago

  • Keywords has-patch added; needs-patch removed

I’ve bumped all the theme versions for WordPress 6.5.

Below is lists,

  • Twenty Ten: 4.1
  • Twenty Eleven: 4.6
  • Twenty Twelve: 4.2
  • Twenty Thirteen: 4.1
  • Twenty Fourteen: 3.9
  • Twenty Fifteen: 3.7
  • Twenty Sixteen: 3.2
  • Twenty Seventeen: 3.5
  • Twenty Nineteen: 2.8
  • Twenty Twenty: 2.5
  • Twenty Twenty-One: 2.1
  • Twenty Twenty-Two: 1.7
  • Twenty Twenty-Three: 1.4

Please check the attached https://core.trac.wordpress.org/attachment/ticket/59816/59816.diff file.

#3 @huzaifaalmesbah
3 months ago

@kushang78
I notice you change some docs @since version
and also Twenty Twenty-Four theme change Requires at least: 6.4 they do not need to be changed.

And maybe you forgot to update the theme version of Twenty Twenty-Four.

@kushang78
3 months ago

Added patch for this ticket.

@kushang78
3 months ago

Added latest patch for this ticket.

#4 @kushang78
3 months ago

@huzaifaalmesbah , Thanks for your feedback

In attached latest patch file, I’ve fixed those things that you have mentioned.

Note: Please consider 59816.19.02.2024.diff patch file as latest.

Thanks!

#5 @shailu25
3 months ago

Thanks @kushang78 for the patch.

There are still Remaining Version changes in below files:

  1. src/wp-content/themes/twentynineteen/package-lock.json
  2. src/wp-content/themes/twentynineteen/package.json
  3. src/wp-content/themes/twentyseventeen/functions.php
  4. src/wp-content/themes/twentytwenty/package-lock.json
  5. src/wp-content/themes/twentytwenty/package.json
  6. src/wp-content/themes/twentytwentyone/assets/css/ie.css
  7. src/wp-content/themes/twentytwentyone/assets/sass/01-settings/file-header.scss
  8. src/wp-content/themes/twentytwentyone/package-lock.json
  9. src/wp-content/themes/twentytwentyone/package.json
  10. src/wp-content/themes/twentytwentyone/style-rtl.css
  11. src/wp-content/themes/twentytwentyfour/style.css
  12. src/wp-content/themes/twentytwentyfour/readme.txt

@kushang78
3 months ago

Added latest patch for this ticket.

#6 @kushang78
3 months ago

@shailu25 , Thanks for your feedback

In attached latest patch file, I’ve fixed those things in all the files that you have mentioned.

Thanks!

#7 @shailu25
3 months ago

Hi @kushang78

Thanks for Update.

One change is still remaining in twentytwentyfour theme.

In readme.txt file stable tag also need to be changed.

@kushang78
3 months ago

#9 @kushang78
3 months ago

I’ve made all the requested changes for this ticket but during uploading the latest patch file, I got “Maximum number of external links per post exceeded” error.

So, Can you please suggest what should I do here?

Please check the attached screenshot of the error.

Thanks!

Last edited 3 months ago by kushang78 (previous) (diff)

#10 follow-up: @poena
3 months ago

@kushang78 I am not sure how to solve that problem, can you describe the steps you took? - I mean what you were doing when the error occurred.

Last edited 3 months ago by poena (previous) (diff)

This ticket was mentioned in Slack in #meta by poena. View the logs.


3 months ago

#12 follow-up: @poena
3 months ago

@kushang78 Are you available to split your patch into multiple smaller .diff files and try to upload them again?

@mukesh27 @desrosj At the latest, at what time in a release does this step need to be completed? Considering RC1 is in a few hours.

#13 @sabernhardt
3 months ago

Smaller .diff files might still have too many links with all of the changelog updates. I'm working on a pull request.

A few blocks stylesheets need newer version numbers too.

  • Twenty Fifteen blocks.css: 20240210
  • Twenty Fifteen editor-blocks.css: 20240117
  • Twenty Sixteen blocks.css: 20240117
  • Twenty Sixteen editor-blocks.css: 20240209

This ticket can go into the RC phase, as similar tickets did for at least the last two major releases (6.4's theme updates were even committed and backported within two hours of the dry run). Of course, completing it before branching would be nice.

This ticket was mentioned in PR #6224 on WordPress/wordpress-develop by @sabernhardt.


3 months ago
#14

Twenty Ten: 4.1
Twenty Eleven: 4.6
Twenty Twelve: 4.2
Twenty Thirteen: 4.1
Twenty Fourteen: 3.9
Twenty Fifteen: 3.7
Twenty Sixteen: 3.2
Twenty Seventeen: 3.6
Twenty Nineteen: 2.8
Twenty Twenty: 2.6
Twenty Twenty-One: 2.2
Twenty Twenty-Two: 1.7
Twenty Twenty-Three: 1.4
Twenty Twenty-Four: 1.1

All of these changelog links point to HelpHub now.

Trac ticket: https://core.trac.wordpress.org/ticket/59816

#15 @desrosj
3 months ago

Agreed that this can be made during RC. This is more of a procedural change that should only be bumping the versions for each theme.

Ideally we're not making it between the last RC and final release, though.

#16 in reply to: ↑ 12 @kushang78
3 months ago

Replying to poena:

@kushang78 Are you available to split your patch into multiple smaller .diff files and try to upload them again?

@mukesh27 @desrosj At the latest, at what time in a release does this step need to be completed? Considering RC1 is in a few hours.


@poena, I Already splitted the patch into multiple smaller .diff (Approx 9-10 .diff files). And then I tried to upload here, Not working facing the same error.

#17 in reply to: ↑ 10 @kushang78
3 months ago

Replying to poena:

@kushang78 I am not sure how to solve that problem, can you describe the steps you took? - I mean what you were doing when the error occurred.


The Steps:

@poena , According to the Comment #comment:8, I've just updated all the changelog codex links url to the latest one for all themes and generated the latest patch. That's it.

I'm agreed with the #comment:13. The Pull request might be the option to make this links related change.

Last edited 3 months ago by kushang78 (previous) (diff)

#18 @poena
3 months ago

PR 6224 looks correct to me,

  • The versions are correct.
  • The new dates for the linked or enqueued CSS files match the release date or the latest changes to the files.
  • The links in the readme are updated.

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


2 months ago

#20 @desrosj
2 months ago

  • Owner set to desrosj
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 months ago

#22 @desrosj
2 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 57886:

Bundled Themes: Bump default theme versions for release with 6.5.

This updates the version of each default theme to the following versions:

  • Twenty Ten: 4.1
  • Twenty Eleven: 4.6
  • Twenty Twelve: 4.2
  • Twenty Thirteen: 4.1
  • Twenty Fourteen: 3.9
  • Twenty Fifteen: 3.7
  • Twenty Sixteen: 3.2
  • Twenty Seventeen: 3.6
  • Twenty Nineteen: 2.8
  • Twenty Twenty: 2.6
  • Twenty Twenty-One: 2.2
  • Twenty Twenty-Two: 1.7
  • Twenty Twenty-Three: 1.4
  • Twenty Twenty-Four: 1.1

These versions will released in coordination with WordPress 6.5.

Props sabernhardt, desrosj, kushang78, mukesh27, huzaifaalmesbah, shailu25, poena.
Fixes #59816.

#24 @desrosj
2 months ago

  • Keywords fixed-major dev-feedback commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport to the 6.5 branch.

#25 @swissspidy
2 months ago

  • Keywords dev-reviewed added; dev-feedback removed

Changes look good to me 👍

#26 @swissspidy
2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57890:

Bundled Themes: Bump default theme versions for release with 6.5.

This updates the version of each default theme to the following versions:

  • Twenty Ten: 4.1
  • Twenty Eleven: 4.6
  • Twenty Twelve: 4.2
  • Twenty Thirteen: 4.1
  • Twenty Fourteen: 3.9
  • Twenty Fifteen: 3.7
  • Twenty Sixteen: 3.2
  • Twenty Seventeen: 3.6
  • Twenty Nineteen: 2.8
  • Twenty Twenty: 2.6
  • Twenty Twenty-One: 2.2
  • Twenty Twenty-Two: 1.7
  • Twenty Twenty-Three: 1.4
  • Twenty Twenty-Four: 1.1

These versions will released in coordination with WordPress 6.5.

Reviewed by swissspidy.
Merges [57886] to the 6.5 branch.

Props sabernhardt, desrosj, kushang78, mukesh27, huzaifaalmesbah, shailu25, poena.
Fixes #59816.

Note: See TracTickets for help on using tickets.