Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#59817 closed task (blessed) (fixed)

Update `$_old_files` for 6.4

Reported by: davidbaumwald's profile davidbaumwald Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.4 Priority: normal
Severity: normal Version: 6.4
Component: Upgrade/Install Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description (last modified by davidbaumwald)

Results of running commands on https://make.wordpress.org/core/handbook/about/release-cycle/releasing-major-versions/#dry-run:

Deleted:

$ svn diff --summarize https://core.svn.wordpress.org/tags/6.3.2 https://core.svn.wordpress.org/branches/6.4 | grep '^D'
D       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/navigation-fallback.php
D       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/navigation/view-modal.min.js
D       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/navigation/view-modal.js

Added:

$ svn diff --summarize https://core.svn.wordpress.org/tags/6.3.2 https://core.svn.wordpress.org/branches/6.4 | grep '^A'
A       https://core.svn.wordpress.org/tags/6.3.2/wp-admin/images/about-header-background.svg
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/block-supports/background.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/image/view.asset.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/image/view.js
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/image/view.min.asset.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/image/view.min.js
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/query/style-rtl.css
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/query/style-rtl.min.css
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/query/style.css
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/query/style.min.css
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/query/view.asset.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/query/view.js
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/query/view.min.asset.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/blocks/query/view.min.js
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/css/dist/patterns/style-rtl.css
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/css/dist/patterns/style-rtl.min.css
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/css/dist/patterns/style.css
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/css/dist/patterns/style.min.css
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/css/dist/patterns
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/fonts/class-wp-font-face-resolver.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/fonts/class-wp-font-face.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/html-api/class-wp-html-active-formatting-elements.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/html-api/class-wp-html-open-elements.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/html-api/class-wp-html-processor-state.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/html-api/class-wp-html-processor.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/html-api/class-wp-html-token.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/html-api/class-wp-html-unsupported-exception.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/js/dist/interactivity.js
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/js/dist/interactivity.min.js
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/js/dist/patterns.js
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/js/dist/patterns.min.js
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/js/dist/undo-manager.js
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/js/dist/undo-manager.min.js
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/rest-api/endpoints/class-wp-rest-template-autosaves-controller.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/rest-api/endpoints/class-wp-rest-template-revisions-controller.php
A       https://core.svn.wordpress.org/tags/6.3.2/wp-includes/fonts.php

Pinging @hellofromTonya & @mike as 6.4 Tech Leads for tracking.

Change History (13)

#1 @samiamnot
2 years ago

Are the following a mistake?

A       https://core.svn.wordpress.org/tags/6.3.2/wp-content/themes/twentytwenty/.npmrc
A       https://core.svn.wordpress.org/tags/6.3.2/wp-content/themes/twentytwentyone/.npmrc

#2 @davidbaumwald
2 years ago

@samiamnot Good question! They were added in https://core.trac.wordpress.org/changeset/56532.

#3 @davidbaumwald
2 years ago

Also got a note from @desrosj that bundled theme files can be excluded from now on... https://core.trac.wordpress.org/ticket/56936

#4 @davidbaumwald
2 years ago

  • Description modified (diff)

I just updated the code blocks in the description to exclude the bundled theme files.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


2 years ago

This ticket was mentioned in PR #5626 on WordPress/wordpress-develop by @hellofromTonya.


2 years ago
#6

  • Keywords has-patch added; needs-patch removed

#7 @hellofromTonya
2 years ago

  • Keywords commit added

Patch: https://github.com/WordPress/wordpress-develop/pull/5626

Adds the deleted files to the $_old_files array. @davidbaumwald did a confidence check and gave a thumbs up. Marking for commit.

#8 @hellofromTonya
2 years ago

  • Owner set to hellofromTonya
  • Resolution set to fixed
  • Status changed from new to closed

In 57075:

Upgrade/Install: Update $_old_files for 6.4.

Props davidbaumwald.
Fixes #59817.

#9 @hellofromTonya
2 years ago

  • Keywords reporter-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 2nd committer sign-off to backport [57075] to 6.4 branch.

#10 @davidbaumwald
2 years ago

  • Keywords dev-reviewed added; reporter-feedback removed

#11 @hellofromTonya
2 years ago

Thank you. Backporting now.

#12 @hellofromTonya
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57076:

Upgrade/Install: Update $_old_files for 6.4.

Reviewed by davidbaumwald.
Merges [57075] to the 6.4 branch.

Props davidbaumwald.
Fixes #59817.

Note: See TracTickets for help on using tickets.