WordPress.org
Get WordPress

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 10 months ago

#59821 closed defect (bug) (fixed)

Irrelevant comment for translators

Reported by: kharisblank's profile kharisblank Owned by: jorbin's profile jorbin
Milestone: 6.4.2 Priority: normal
Severity: normal Version: 6.4
Component: I18N Keywords: has-patch fixed-major
Focuses: ui-copy Cc:

Description

While reviewing translation for WordPress 6.4.x. I found this string has irrelevant comment.

​https://translate.wordpress.org/projects/wp/dev/admin/id/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=16513377&filters%5Btranslation_id%5D=110272891

https://i.snipboard.io/Lt6iSP.jpg

My guess it should look like this (attached screenshot below), where it has comment for each variable.

https://i.snipboard.io/tQUERH.jpg

Change History (11)

#1 @jorbin
11 months ago

  • Focuses accessibility removed
  • Keywords needs-patch added

Thanks @kharisblank and sorry for the bad comment. I am going to move this into the 6.4.1 milestone after that is created.

#2 @SergeyBiryukov
11 months ago

  • Milestone changed from Awaiting Review to 6.4.1

This ticket was mentioned in ​PR #5629 on ​WordPress/wordpress-develop by ​@kebbet.
11 months ago #3

  • Keywords has-patch added; needs-patch removed

https://core.trac.wordpress.org/ticket/59821

#4 @jorbin
11 months ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 57081:

Help/About: Improve translation comment around release notes.

Props kharisblank, kebbet.
Fixes #59821.

#5 @jorbin
11 months ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for consideration of backport to 6.4.

#6 @SergeyBiryukov
11 months ago

  • Keywords fixed-major added; dev-feedback removed

[57081] looks good to backport.

#7 @jorbin
11 months ago

  • Milestone changed from 6.4.1 to 6.4.2

​@SergeyBiryukov commented on ​PR #5629:
11 months ago #8

Thanks for the PR! This was merged in r57081.

#9 @jorbin
11 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57112:

Help/About: Improve translation comment around release notes.

Reviewed by SergeyBiryukov.
Merges [57081] to the 6.4 branch.

Props kharisblank, kebbet.
Fixes #59821.

#10 @sabernhardt
10 months ago

r57113:
Remove unintended changes introduced in [57112].

This ticket was mentioned in ​Slack in #core by jorbin. ​View the logs.
10 months ago

Note: See TracTickets for help on using tickets.