Context Navigation

← Previous Ticket
Next Ticket →

#59821 closed defect (bug) (fixed)

Irrelevant comment for translators

Reported by:	kharisblank	Owned by:	jorbin
Priority:	normal	Milestone:	6.4.2
Component:	I18N	Version:	6.4
Severity:	normal	Keywords:	has-patch fixed-major
Cc:		Focuses:	ui-copy

Description

While reviewing translation for WordPress 6.4.x. I found this string has irrelevant comment.

https://translate.wordpress.org/projects/wp/dev/admin/id/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=16513377&filters%5Btranslation_id%5D=110272891

My guess it should look like this (attached screenshot below), where it has comment for each variable.

Change History (11)

#1 @jorbin
3 years ago

Focuses accessibility removed
Keywords needs-patch added

Thanks @kharisblank and sorry for the bad comment. I am going to move this into the 6.4.1 milestone after that is created.

#2 @SergeyBiryukov
3 years ago

Milestone Awaiting Review → 6.4.1

This ticket was mentioned in PR #5629 on WordPress/wordpress-develop by @kebbet.

3 years ago #3

Keywords has-patch added; needs-patch removed

https://core.trac.wordpress.org/ticket/59821

#4 @jorbin
3 years ago

Owner set to jorbin
Resolution → fixed
Status new → closed

In 57081:

Help/About: Improve translation comment around release notes.

Props kharisblank, kebbet.
Fixes #59821.

#5 @jorbin
3 years ago

Keywords dev-feedback added
Resolution fixed
Status closed → reopened

Reopening for consideration of backport to 6.4.

#6 @SergeyBiryukov
3 years ago

Keywords fixed-major added; dev-feedback removed

[57081] looks good to backport.

#7 @jorbin
3 years ago

Milestone 6.4.1 → 6.4.2

@SergeyBiryukov commented on PR #5629:

3 years ago #8

Thanks for the PR! This was merged in r57081.

#9 @jorbin
3 years ago

Resolution → fixed
Status reopened → closed

In 57112:

Help/About: Improve translation comment around release notes.

Reviewed by SergeyBiryukov.
Merges [57081] to the 6.4 branch.

Props kharisblank, kebbet.
Fixes #59821.

#10 @sabernhardt
3 years ago

r57113:
Remove unintended changes introduced in [57112].

This ticket was mentioned in Slack in #core by jorbin. View the logs.

3 years ago

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#59821 closed defect (bug) (fixed)

Irrelevant comment for translators

Description

Change History (11)

#1 @jorbin 3 years ago

#2 @SergeyBiryukov 3 years ago

This ticket was mentioned in ​PR #5629 on ​WordPress/wordpress-develop by ​@kebbet. 3 years ago #3

#4 @jorbin 3 years ago

#5 @jorbin 3 years ago

#6 @SergeyBiryukov 3 years ago

#7 @jorbin 3 years ago

​@SergeyBiryukov commented on ​PR #5629: 3 years ago #8

#9 @jorbin 3 years ago

#10 @sabernhardt 3 years ago

This ticket was mentioned in ​Slack in #core by jorbin. ​View the logs. 3 years ago