WordPress.org
Get WordPress

Make WordPress Core

Opened 3 weeks ago

Last modified 6 days ago

#59828 new defect (bug)

Update npm packages with bugfixes for 6.4.2

Reported by: jorbin's profile jorbin Owned by:
Milestone: 6.4.2 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch dev-feedback commit
Focuses: Cc:

Description

Some changes in the editor will need to be cherry picked and included in WordPress 6.4.1. This is a tracking ticket for those

Change History (22)

#1 @jorbin
3 weeks ago

​https://github.com/WordPress/gutenberg/pull/55361 is a bug that TT4 highlights and I think would be good to bring in the fix for.

#2 @kebbet
3 weeks ago

I’m adding this PR to get it on the radar here too.

It’s an issue with the context of multiple pattern strings.
​https://github.com/WordPress/gutenberg/pull/55935

#3 @jorbin
3 weeks ago

  • Milestone changed from 6.4.1 to 6.4.2
  • Summary changed from Update npm packages with bugfixes for 6.4.1 to Update npm packages with bugfixes for 6.4.2

#4 @mikachan
2 weeks ago

#59898 was marked as a duplicate.

This ticket was mentioned in ​Slack in #core by mikachan. ​View the logs.
2 weeks ago

​@isabel_brison commented on ​PR #5665:
2 weeks ago #7

Noting that the following changes were also included in this PR:

​Add check for lightbox values during image block migration

​Add context for translators to any unclear usage of "synced"

​Patterns: use existing download function for JSON downloads to fix no…

This is as expected because they were all marked for inclusion in the next minor release.

#8 @isabel_brison
2 weeks ago

In 57109:

Editor: update npm packages for 6.4.2.

Package updates with bug fixes related to patterns, Query look interactivity, design tools UI and accessibility.

Props mikachan, jorbin, kebbet, artemiosans, talldanwp, ramonopoly, alexstine, andrewserong, mamaduka, cbravobernal, ajlende, luisherranz.
See #59828.

#9 @isabel_brison
2 weeks ago

  • Keywords dev-feedback commit added

​@isabel_brison commented on ​PR #5665:
2 weeks ago #10

Committed in r57109. Leaving this open for commit to the release branch though not sure if it's best to point this PR at the release branch instead of trunk or just open a new one (we should in any case check CI passes with this diff against the release branch)

​@mikachan commented on ​PR #5665:
2 weeks ago #11

Thanks so much for helping with this and testing!

One thing I'm slightly puzzled about is why all the packages are getting version bumps.

This has been mentioned before during the 6.4 cycle but I can't find where right now. I vaguely remember it being mentioned and it was fine for now, but going into 6.5 maybe we should look more closely at this. 😅

I don't know if there's been an update to the publishing actions or if Lerna has been updated, but it's almost as if Lerna has no context for the current changes, so it assumes everything needs a version bump. I'm not sure what's changed between 6.3 and 6.4 though - maybe @gziolo knows more?

​@gziolo commented on ​PR #5665:
2 weeks ago #12

After checking the publishing job I can share that I identified the reason why we still see all packages published. I landed some time ago the fix in the Gutenberg repository that potentially addresses the issue encountered with ​https://github.com/WordPress/gutenberg/pull/55334 but it only impacts trunk. For not fully clear to me reasons, the publishing targeting the WP 6.4 release gets triggered from GitHub UI using the wp/6.4 branch. In effect, the publishing workflow doesn't use the patched version. To address it we should do two things:

  • Update the docs to make it clear that publishing workflow is triggered using the latest code from trunk.
  • Cherry-pick the linked PR to wp/6.4 in case the workflow get still triggered from the branch.

​@mikachan commented on ​PR #5665:
2 weeks ago #13

Ah this makes sense, thanks @gziolo! I hadn't seen ​https://github.com/WordPress/gutenberg/pull/55334.

For not fully clear to me reasons, the publishing targeting the WP 6.4 release gets triggered from GitHub UI using the wp/6.4 branch.

@SiobhyB and I discussed this early in the 6.4 cycle and we decided to go with publishing the packages targeting the wp/6.4 branch as we thought this was safer and would limit any potential unexpected issues, and we'd also seen a mix of publishing both from trunk and from the wp/X.Y branch in past runs. I guess we technically limited any issues but also missed a fix 😅

Update the docs to make it clear that publishing workflow is triggered using the latest code from trunk.

The ​docs screenshot does show the target as trunk, but this isn't mentioned in the text description. This sentence also threw me off: Now, the wp/X.Y branch is ready for publishing npm packages.. I had assumed this also meant "run from the wp/X.Y branch", so perhaps we could update this wording. It also didn't feel right to run the package updates from trunk, especially as all the other related work is based on the wp/X.Y branch.

Cherry-pick the linked PR to wp/6.4 in case the workflow get still triggered from the branch.

I'm happy to help handle this.

​@isabel_brison commented on ​PR #5665:
2 weeks ago #14

Oh I see, thanks @gziolo !

Update the docs to make it clear that publishing workflow should get triggered using the latest code from trunk.
Cherry-pick the linked PR to wp/6.4 in case the workflow get still triggered from the branch.

I agree with @mikachan that the docs could be more explicit about which branch to trigger the workflow from, as I also found that super confusing in the past 😅
Happy to go in and change that!

Cherry picking the fix to the release branch would also be good to avoid confusing anyone packaging a minor release from this branch in the future.

​@gziolo commented on ​PR #5665:
2 weeks ago #15

I cherry-picked ​https://github.com/WordPress/gutenberg/commit/1dd31459ba0a45c62adbcc4ae2fbd15dbed681e4 in the wp.6.4 branch in Gutenberg that should resolve the issue.

I agree with @mikachan that the docs could be more explicit about which branch to trigger the workflow from, as I also found that super confusing in the past 😅
Happy to go in and change that!

Let's do it as well, as it might prevent similar issues in the future. I understand how the combo box for selecting the branch might confuse people. The intention GitHub has with it is to allow the selection of the branch from which the GitHub workflow file is going to be read on CI. In effect, when selecting the wp/6.4 this is the current workflow (with the patch applied) that is going to get triggered:

​https://github.com/WordPress/gutenberg/blob/wp/6.4/.github/workflows/publish-npm-packages.yml

This ticket was mentioned in ​Slack in #core by jorbin. ​View the logs.
13 days ago

​@mikachan commented on ​PR #5665:
7 days ago #17

Committed in r57109. Leaving this open for commit to the release branch though not sure if it's best to point this PR at the release branch instead of trunk or just open a new one (we should in any case check CI passes with this diff against the release branch)

@tellthemachines, you mentioned above that we may either need to point this PR at the release branch (I guess this is 6.4?) or open a new one. Which one would you recommend?

Also, we have one more change that needs to be included in the package update. I'm in the process of updating the packages again ​here - should I create a new PR for this, or include it in this PR? I know this PR has already been committed to trunk, so I'm guessing it's best to open a new PR.

​@isabel_brison commented on ​PR #5665:
7 days ago #18

Also, we have one more change that needs to be included in the package update.

@mikachan in that case it's probably easier to open a new PR for trunk with that extra change, and then assuming it's all good, open a third PR for the release branch including all the changes.

​@mikachan commented on ​PR #5665:
6 days ago #19

in that case it's probably easier to open a new PR for trunk with that extra change, and then assuming it's all good, open a third PR for the release branch including all the changes.

Will do, thank you!

​@mikachan commented on ​PR #5665:
6 days ago #22

Here's the new PR for trunk with the single extra change: ​https://github.com/WordPress/wordpress-develop/pull/5696

The tests seem good, although it looks like there's an error with the Playground build process ​here. I'm not sure if that's a blocker or not.

I went ahead and created a PR against the release branch too with all the changes: ​https://github.com/WordPress/wordpress-develop/pull/5698. All the tests passed here.

Thanks so much for your help 🙇

Note: See TracTickets for help on using tickets.