Make WordPress Core

Opened 9 months ago

Closed 6 months ago

Last modified 6 months ago

#59838 closed enhancement (fixed)

Twenty Twenty-Four: Missing license information in the readme.txt

Reported by: acosmin's profile acosmin Owned by: swissspidy's profile swissspidy
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.4
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:


The readme.txt file is missing license information on the fonts bundled (../assets/fonts/) with this theme

Attachments (2)

59838.patch (1.4 KB) - added by shailu25 7 months ago.
Patch Added
59838.2.patch (1.4 KB) - added by shailu25 7 months ago.
Patch Added

Download all attachments as: .zip

Change History (13)

#2 @acosmin
9 months ago

It's common practice and we've required theme authors to include license information in the readme.txt file for any assets bundled with the theme.

Please read, "Bundled Resource Copyright Attribution" section

This ticket was mentioned in Slack in #core by jorbin. View the logs.

9 months ago

#4 @sabernhardt
8 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 6.5

Thanks for the report! I missed PR 493, which removed the attribution. It should have been retained in addition to the license file.

  • Twenty Twenty's initial version had credits for Inter (PR 424 and PR 619).
  • Twenty Twenty-Two also had the attribution in its initial version for Source Serif (PR 8), plus the three alternate fonts when they were included in #55433.
  • Twenty Twenty-Three recently added font credits to the readme in #59483.

7 months ago

Patch Added

7 months ago

Patch Added

#5 @shailu25
7 months ago

  • Keywords has-patch added; needs-patch removed

Added font License information in the readme.txt file.

#6 @poena
6 months ago

The license information in both patches are correct.

But I am not able to apply the patches on Windows 11.
First, the file to patch cannot be located from the root directory. I can solve this by removing a/ and b/ from the three file paths manually.

Next, the error message in the terminal says: FAILED at 48 (different line endings). I tried switching between LF and CRLF multiple times, but it did not solve the problem. This is probably something on my side on Windows. It did not make a difference if I tried to apply patch 1, or patch 2 which has an empty line at the end.

#7 @sabernhardt
6 months ago

I did not have any trouble applying the patch in Windows 10. However, if the readme file says "This theme bundles the following third-party resources," that would belong before both the fonts and the images. I'll make a pull request with the fonts' information first.

This ticket was mentioned in PR #5914 on WordPress/wordpress-develop by @sabernhardt.

6 months ago

  • Adds font information before the image credits
  • Keeps the "Fonts" and "Images" headings
  • Uses consistent text for the SIL Font License

Trac 59838

#9 @poena
6 months ago

  • Keywords commit added

I was able to apply PR 5914 and it looks correct, thank you.

#10 @swissspidy
6 months ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 57324:

Twenty Twenty-Four: Update license information in readme.

Adds missing license information for bundled fonts.

Props acosmin, shailu25, poena, sabernhardt.
Fixes #59838

Note: See TracTickets for help on using tickets.