Twenty Twenty-Four: Missing license information in the readme.txt

[acosmin]

The readme.txt file is missing license information on the fonts bundled (../assets/fonts/) with this theme

​https://themes.trac.wordpress.org/browser/twentytwentyfour/1.0/assets/fonts
​https://themes.trac.wordpress.org/browser/twentytwentyfour/1.0/readme.txt

[onemaggie]

The license files are inside the fonts folders, just like TT2 did

​https://themes.trac.wordpress.org/browser/twentytwentyfour/1.0/assets/fonts/cardo/LICENSE.txt

[acosmin]

It's common practice and we've required theme authors to include license information in the readme.txt file for any assets bundled with the theme.

Please read ​https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/, "Bundled Resource Copyright Attribution" section

[sabernhardt]

Thanks for the report! I missed ​PR 493, which removed the attribution. It should have been retained in addition to the license file.

• Twenty Twenty's initial version had credits for Inter (​PR 424 and ​PR 619).
• Twenty Twenty-Two also had the attribution in its initial version for Source Serif (​PR 8), plus the three alternate fonts when they were included in #55433.
• Twenty Twenty-Three recently added font credits to the readme in #59483.

[shailu25]

Patch Added

[shailu25]

Patch Added

[shailu25]

Added font License information in the readme.txt file.

[poena]

Hi
The license information in both patches are correct.

But I am not able to apply the patches on Windows 11.
First, the file to patch cannot be located from the root directory. I can solve this by removing a/ and b/ from the three file paths manually.

Next, the error message in the terminal says: FAILED at 48 (different line endings). I tried switching between LF and CRLF multiple times, but it did not solve the problem. This is probably something on my side on Windows. It did not make a difference if I tried to apply patch 1, or patch 2 which has an empty line at the end.

[sabernhardt]

I did not have any trouble applying the patch in Windows 10. However, if the readme file says "This theme bundles the following third-party resources," that would belong before both the fonts and the images. I'll make a pull request with the fonts' information first.

• Adds font information before the image credits
• Keeps the "Fonts" and "Images" headings
• Uses consistent text for the SIL Font License

Trac 59838

[poena]

I was able to apply PR 5914 and it looks correct, thank you.

[swissspidy]

In 57324:

Twenty Twenty-Four: Update license information in readme.

Adds missing license information for bundled fonts.

Props acosmin, shailu25, poena, sabernhardt.
Fixes #59838

committed in https://core.trac.wordpress.org/changeset/57324