WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#59840 closed defect (bug) (fixed)

Twenty Twenty-Four: register_block_pattern_category()'s proprieties are missing the theme's textdomain

Reported by: acosmin Owned by: SergeyBiryukov
Priority: normal Milestone: 6.4.3
Component: Bundled Theme Version: 6.4
Severity: normal Keywords: good-first-bug has-patch commit fixed-major dev-reviewed
Cc: Focuses:

Description

​https://themes.trac.wordpress.org/browser/twentytwentyfour/1.0/functions.php#L199
​https://themes.trac.wordpress.org/browser/twentytwentyfour/1.0/functions.php#L200

Change History (15)

#1 @acosmin
3 years ago

  • Component General → Bundled Theme

#2 @acosmin
3 years ago

The label can probably use the Core translation, but the description doesn't seem to be included.

#3 @afercia
3 years ago

  • Keywords needs-patch added
  • Milestone Awaiting Review → 6.4.2
  • Severity major → normal

#4 @afercia
3 years ago

  • Keywords good-first-bug added

Milestoning for next minor release, as this is a small, self-contained fix.

This ticket was mentioned in ​PR #5659 on ​WordPress/wordpress-develop by ​gavande1.
3 years ago #5

  • Keywords has-patch added; needs-patch removed

Trac ticket: #59840

#6 @huzaifaalmesbah
3 years ago

Thanks For adding Patch @gavande1. I saw your patch ​5659.diff Everything is ok.

#7 @ironprogrammer
3 years ago

  • Keywords commit added

I've also reviewed the patch, LGTM 👍🏻

Marking for commit consideration.

#8 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 57127:

Twenty Twenty-Four: Add missing textdomain in pattern category description.

Follow-up to [56951].

Props gavande1, acosmin, afercia, huzaifaalmesbah, ironprogrammer.
Fixes #59840.

​@SergeyBiryukov commented on ​PR #5659:
3 years ago #9

Thanks for the PR! Merged in r57127.

#10 @SergeyBiryukov
3 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Reopening for backporting to the 6.4 branch.

#11 @SergeyBiryukov
3 years ago

  • Milestone 6.4.2 → 6.4.3

This ticket was mentioned in ​Slack in #core by jorbin. ​View the logs.
3 years ago

#13 @jorbin
3 years ago

  • Keywords dev-feedback added

#14 @jorbin
3 years ago

  • Keywords dev-reviewed added; dev-feedback removed

I've reviewed [57127] and it is good for backport.

#15 @peterwilsoncc
3 years ago

  • Resolution → fixed
  • Status reopened → closed

In 57307:

Twenty Twenty-Four: Add missing textdomain in pattern category description.

Follow-up to [56951].

Reviewed by jorbin.
Merges [57127] to the 6.4 branch.

Props gavande1, acosmin, afercia, huzaifaalmesbah, ironprogrammer, SergeyBiryukov.
Fixes #59840.

Note: See TracTickets for help on using tickets.