Make WordPress Core

Opened 4 weeks ago

Last modified 2 days ago

#59840 reopened defect (bug)

Twenty Twenty-Four: register_block_pattern_category()'s proprieties are missing the theme's textdomain

Reported by: acosmin's profile acosmin Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.4.3 Priority: normal
Severity: normal Version: 6.4
Component: Bundled Theme Keywords: good-first-bug has-patch commit fixed-major
Focuses: Cc:

Change History (11)

#1 @acosmin
4 weeks ago

  • Component changed from General to Bundled Theme

#2 @acosmin
4 weeks ago

The label can probably use the Core translation, but the description doesn't seem to be included.

#3 @afercia
4 weeks ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 6.4.2
  • Severity changed from major to normal

#4 @afercia
4 weeks ago

  • Keywords good-first-bug added

Milestoning for next minor release, as this is a small, self-contained fix.

This ticket was mentioned in PR #5659 on WordPress/wordpress-develop by gavande1.

4 weeks ago

  • Keywords has-patch added; needs-patch removed

Trac ticket: #59840

#6 @huzaifaalmesbah
4 weeks ago

Thanks For adding Patch @gavande1. I saw your patch 5659.diff Everything is ok.

#7 @ironprogrammer
3 weeks ago

  • Keywords commit added

I've also reviewed the patch, LGTM 👍🏻

Marking for commit consideration.

#8 @SergeyBiryukov
3 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57127:

Twenty Twenty-Four: Add missing textdomain in pattern category description.

Follow-up to [56951].

Props gavande1, acosmin, afercia, huzaifaalmesbah, ironprogrammer.
Fixes #59840.

@SergeyBiryukov commented on PR #5659:

3 weeks ago

Thanks for the PR! Merged in r57127.

#10 @SergeyBiryukov
3 weeks ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 6.4 branch.

#11 @SergeyBiryukov
2 days ago

  • Milestone changed from 6.4.2 to 6.4.3
Note: See TracTickets for help on using tickets.