Changes between Initial Version and Version 1 of Ticket #59847, comment 34
- Timestamp:
- 11/09/2023 04:12:31 PM (15 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #59847, comment 34
initial v1 1 @joemcgill Had a thought about the memoization so drop it in here as a possible consideration going forwards. Previously, `get_stylesheet_directory()` always returned a string value regardless of the stack and how early it was called.1 @joemcgill Had a thought about the memoization so wanted to drop it in here as a possible consideration going forwards. Previously, `get_stylesheet_directory()` always returned a string value regardless of the stack and how early it was called. 2 2 3 3 With memoization and the proposed PR, there are cases when early calls to `get_stylesheet_directory()` will return as null. Are there potential concerns if the value is null on early calls? This doesn't directly affect anything I'm attempting to do on the plugin end as my hook will assign it as expected, but it might be something to consider from a higher WP level.