Make WordPress Core

Opened 7 months ago

Closed 5 months ago

Last modified 5 months ago

#59858 closed defect (bug) (fixed)

A typo in the parameter description of the wp_print_font_faces function

Reported by: tmatsuur's profile tmatsuur Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.4
Component: General Keywords: has-patch commit
Focuses: docs Cc:

Description

I was looking at the newly added functions and found something strange.

Line 25 of file wp-includes/fonts.php

 *             @type string          $font_style              Optional. The font-style property. Default 'normal'.

Here it is $font_style, but I think the correct name is $font-style.

For confirmation, "font_style" => "oblique 20deg 50deg" produces the output "font-style:normal;".

On the other hand, when "font-style" => "oblique 20deg 50deg" is written, the output is changed to "font-style:oblique 20deg 50deg;" as expected.

Change History (6)

This ticket was mentioned in PR #5645 on WordPress/wordpress-develop by @rajinsharwar.


7 months ago
#1

  • Keywords has-patch added

Fixing the typo in $font-style doc block.
Trac ticket: https://core.trac.wordpress.org/ticket/59858

#3 @audrasjb
7 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.5
  • Owner set to audrasjb
  • Status changed from new to accepted

Thanks for spotting this! Self assigning for commit consideration.

#4 @hellofromTonya
5 months ago

  • Owner changed from audrasjb to hellofromTonya
  • Status changed from accepted to assigned

Whoopsie. Thanks for catching this typo. Reassigning commit to me.

#5 @hellofromTonya
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 57240:

Fonts: Fix font_style typo in wp_print_font_faces().

Changes font_style to font-style to reflect the CSS property.

Follow-up to [56540].

Props tmatsuur, rajinsharwar, audrasjb.
Fixes #59858.

Note: See TracTickets for help on using tickets.