Make WordPress Core

Opened 3 years ago

Last modified 4 months ago

#59880 new defect (bug)

Twenty Thirteen: Pullquote block having no effect when we change font-size

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Future Release Priority: normal
Severity: minor Version: 6.4
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Steps to reproduce the issue :-

  1. Activate Twenty Thirteen theme.
  2. Choose Pullquote block.
  3. Add some text
  4. Change in font size.

You can able to see there is no difference in both the side in fonts.
I have attached video for better understanding.
Video URL:- https://share.cleanshot.com/pJgXND8tksl8PqXCL0sJ

Attachments (2)

59880.patch (934 bytes) - added by nidhidhandhukiya 3 years ago.
59880.1.patch (1.6 KB) - added by sabernhardt 4 months ago.
Sets blockquote font size to 1em if the Pullquote block has a custom font size, and updates editor class names

Download all attachments as: .zip

Change History (13)

#1 @harshgajipara
3 years ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/59880/59880.patch

Environment

OS: Windows
PHP: 8.1.9
WordPress: 6.4
Browser: Chrome
Theme: Twenty Thirteen
Plugins: None activated

Actual Results:

✅ Before patch: Pull quote block font size change is not working.
Backend: https://prnt.sc/bv5jkP24bPPh
Frontend: https://prnt.sc/u2YCFLVZav9H

✅ After patch: Pull quote block font size change is working.
Backend: https://prnt.sc/R2sOdSsfgKhG
Frontend: https://prnt.sc/LFWZM6TleKA5

#3 @darshitrajyaguru97
3 years ago

Test Repost for https://core.trac.wordpress.org/attachment/ticket/59880/59880.patch

Environment:
===========
PHP: 8.1.9
WordPress: 6.4
Browser: Chrome
Theme: Twenty Thirteen
Plugin: None

Screenshots:
===========
Before Patch Screenshots:
Backend: https://prnt.sc/R06Ykc1gxc8n
Frontend: https://prnt.sc/7KBrlVc_eoYG

After Patch Screenshots:
Backend: https://prnt.sc/RO-uyipkNhFy
Frontend: https://prnt.sc/6vdJmPWtm_-y

Patch is working very well.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


2 years ago

This ticket was mentioned in Slack in #core-themes by jorbin. View the logs.


2 years ago

#6 @yuvrajsinh2211
2 years ago

Testing of Patch: https://core.trac.wordpress.org/attachment/ticket/59880/59880.patch

Tested in the below environment:

PHP: 8.1.9
WordPress: 6.4
Theme: Twenty Thirteen
Browser: Chrome
Plugin: No plugins


Before Patch Screenshots:
Backend: https://prnt.sc/jAyz_ZwTNTyI
Frontend: https://prnt.sc/dtwP_T1nIDgu


After Patch Screenshots:
Backend: https://prnt.sc/Mb3TccriU8jW
Frontend: https://prnt.sc/AEImT47kIS85

As tested, Patch is working properly.

#7 @karmatosed
2 years ago

  • Keywords has-patch added

#8 @karmatosed
22 months ago

  • Milestone changed from Awaiting Review to Future Release

#9 @poena
18 months ago

  • Keywords changes-requested added

Hi

The suggested patch removes the default styles, this breaks the original design and it would be an unexpected change on live sites.

The default font size needs to remain the same, and the size from the block controls need to override it.

#10 @sabernhardt
5 months ago

  • Keywords close 2nd-opinion added
  • Summary changed from Twenty Thirteen - Pullquote block having no effect when we change font-size. to Twenty Thirteen: Pullquote block having no effect when we change font-size

GB11610 started to deprecate the Pullquote block for WordPress 7.0, so it might not be worth updating Twenty Thirteen's CSS for the block at this time.

If still desired, both blocks.css and editor-blocks.css could include something like this:

.wp-block-pullquote:where([class*="-font-size"], [style*="font-size"]) blockquote {
	font-size: 1em;
}

@sabernhardt
4 months ago

Sets blockquote font size to 1em if the Pullquote block has a custom font size, and updates editor class names

#11 @sabernhardt
4 months ago

  • Keywords changes-requested close 2nd-opinion removed

GB75122 restored the Pullquote block.

In addition to assigning 1em to honor user-specified font sizes, 59880.1.patch updates selectors in the editor styles. This makes the citation font size 16 pixels to match the front. Some people could prefer a relative value, both on the front and in the editor, but I think it is very late to change the citation size on the front end.

Note: See TracTickets for help on using tickets.