Make WordPress Core

Opened 13 months ago

Last modified 5 days ago

#59880 new defect (bug)

Twenty Thirteen - Pullquote block having no effect when we change font-size.

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Future Release Priority: normal
Severity: minor Version: 6.4
Component: Bundled Theme Keywords: has-patch changes-requested
Focuses: Cc:

Description

Steps to reproduce the issue :-

  1. Activate Twenty Thirteen theme.
  2. Choose Pullquote block.
  3. Add some text
  4. Change in font size.

You can able to see there is no difference in both the side in fonts.
I have attached video for better understanding.
Video URL:- https://share.cleanshot.com/pJgXND8tksl8PqXCL0sJ

Attachments (1)

59880.patch (934 bytes) - added by nidhidhandhukiya 13 months ago.

Download all attachments as: .zip

Change History (10)

#1 @harshgajipara
13 months ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/59880/59880.patch

Environment

OS: Windows
PHP: 8.1.9
WordPress: 6.4
Browser: Chrome
Theme: Twenty Thirteen
Plugins: None activated

Actual Results:

✅ Before patch: Pull quote block font size change is not working.
Backend: https://prnt.sc/bv5jkP24bPPh
Frontend: https://prnt.sc/u2YCFLVZav9H

✅ After patch: Pull quote block font size change is working.
Backend: https://prnt.sc/R2sOdSsfgKhG
Frontend: https://prnt.sc/LFWZM6TleKA5

#3 @darshitrajyaguru97
13 months ago

Test Repost for https://core.trac.wordpress.org/attachment/ticket/59880/59880.patch

Environment:
===========
PHP: 8.1.9
WordPress: 6.4
Browser: Chrome
Theme: Twenty Thirteen
Plugin: None

Screenshots:
===========
Before Patch Screenshots:
Backend: https://prnt.sc/R06Ykc1gxc8n
Frontend: https://prnt.sc/7KBrlVc_eoYG

After Patch Screenshots:
Backend: https://prnt.sc/RO-uyipkNhFy
Frontend: https://prnt.sc/6vdJmPWtm_-y

Patch is working very well.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


12 months ago

This ticket was mentioned in Slack in #core-themes by jorbin. View the logs.


12 months ago

#6 @yuvrajsinh2211
12 months ago

Testing of Patch: https://core.trac.wordpress.org/attachment/ticket/59880/59880.patch

Tested in the below environment:

PHP: 8.1.9
WordPress: 6.4
Theme: Twenty Thirteen
Browser: Chrome
Plugin: No plugins


Before Patch Screenshots:
Backend: https://prnt.sc/jAyz_ZwTNTyI
Frontend: https://prnt.sc/dtwP_T1nIDgu


After Patch Screenshots:
Backend: https://prnt.sc/Mb3TccriU8jW
Frontend: https://prnt.sc/AEImT47kIS85

As tested, Patch is working properly.

#7 @karmatosed
8 months ago

  • Keywords has-patch added

#8 @karmatosed
4 months ago

  • Milestone changed from Awaiting Review to Future Release

#9 @poena
5 days ago

  • Keywords changes-requested added

Hi

The suggested patch removes the default styles, this breaks the original design and it would be an unexpected change on live sites.

The default font size needs to remain the same, and the size from the block controls need to override it.

Note: See TracTickets for help on using tickets.