#59906 closed enhancement (invalid)
Navigation link block variations - Maybe backport into core
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | Editor | Keywords: | |
| Focuses: | Cc: |
Description
In Gutenberg PR 54801 some functions were added to the navigation link blocks php file to register variations for all post types/taxonomies.
@andraganescu asked me to open a ticket here, to check if those changes would need to be manually backported and moved somewhere else in core?
As I understand, if those should just stay in the blocks index.php file, they will get merged into core with the gutenberg packages update. But since those are a few functions and the blocks php file is getting longer, it may make sense to put them somewhere else?
Also there's another PR which fixes some things in this functionality and also a PR for the post-terms block which handles the same thing.
So there are two blocks which hook into registered_post_type/registered_taxonoomy. A point could be made, to combine those two. But I think, having them in the blocks directly, is more clear.
According to https://github.com/WordPress/gutenberg/pull/56100#issuecomment-1903946767 no backporting is necessary.