Twenty Sixteen : PullQuote block Typography option is not working properly

[pranitdugad]

In Twenty Sixteen, The PullQuote block Typography option is not working properly. if we compare it with other themes when we change the typography size the whole content of the PullQuote Block changes.
Here is the Video for proper understanding :
​https://drive.google.com/file/d/1oFolq5vcgiZVZlXfMV-k5Q34If3m6N61/view?usp=sharing

[jorbin]

Thank you @pranitdugad for the ticket and @nidhidhandhukiya for the patch.

Moving to 6.5 for visibility during the next core cycle.

For testing, I think it's important to ensure that 1) Existing Pull Quotes look the same on the front end and 2) the controls in the editor work as expected.

[darshitrajyaguru97]

Test Report for https://core.trac.wordpress.org/attachment/ticket/59919/59919.patch

Environment:
============
PHP: 8.1.9
WordPress: 6.4
Browser: Chrome
Theme: Twenty Sixteen
Plugin: none

Screenshots:
===========
Before Patch Screenshots:
Backend: ​https://prnt.sc/JoV4am2Ctlqz
Frontend: ​https://prnt.sc/ew6R5Jadhdmb

After Patch Screenshots:
Backend: ​https://prnt.sc/nd15M05cvhTl
Frontend: ​https://prnt.sc/WbTSZe6aYdP2

Patch is working well.

[yuvrajsinh2211]

Testing of: https://core.trac.wordpress.org/attachment/ticket/59919/59919.patch

Tested in the below environment:

PHP: 8.1.9
WordPress: 6.4
Theme: Twenty-Sixteen
Browser: Chrome
Plugin: No plugins

---

Before Patch Screenshot:

Backend: ​https://prnt.sc/u5ukHAPft3DK
Frontend: ​https://prnt.sc/QV1KbXhqnToY

---

After-Patch Screenshot:

Backend: ​https://prnt.sc/CP0JPCKQ7gHi
Frontend: ​https://prnt.sc/xSGGn9JP-OO-

As tested, Patch is working properly.

[Ankit K Gupta]

Test Report ✅

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/59919/59919.patch

Environment

• WordPress: 6.5-alpha-20231215.233054
• PHP: 7.4.30
• Server: nginx/1.16.0
• Database: mysqli (Server: 5.7.28 / Client: mysqlnd 7.4.30)
• Browser: Chrome 120.0.0.0
• OS: macOS
• Theme: Twenty Sixteen 3.1
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.0.0

Actual Results

✅ Issue resolved with patch.

Before the Fix/patch:

​https://screencast-o-matic.com/watch/c0loFiVHnlz

After the Fix/patch:

​https://screencast-o-matic.com/watch/c0loFXVHnlW

[poena]

Hi
Thank you for working on this ticket.
I have tested patch https://core.trac.wordpress.org/attachment/ticket/59919/59919.patch and would like to make the following change requests:

• The patch removes the font size from both the pullquote block and the blockquote HTML element.

This means that the quote added in the classic editor, and the quote block, are also affected, not only the pullquote block.
Expected: The classic quote and quote block should remain unchanged or be improved.

• When the font-size option is not used, the font size does not match the previous size.

So the default size is smaller than it was before the patch, and this is an unexpected change on live websites.
Expected: The default font size for both the pullquote content and the cite should be the same as before the patch.

• When the font-size option is not used, the sizes in the editor and front does not match.

Expected: The editor and front should match.

---

Note: When the font size is removed, the block uses the default font size that WordPress adds here:
​https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/pullquote/block.json#L67
But this only works on the front.

[sabernhardt]

#58607 was marked as a duplicate.

[shailu25]

Updated patch

[shailu25]

Updated patch as per suggested in above comment.

• In Pullquote block when font size is selected in editor, it will show selected font size's font, else it will show default font size.
• Also fixed line height issue in both front-end side & in editor.

[shailu25]

Removed extra space in patch (block.css)

[karmatosed]

In testing this doesn't apply font changes what it does it just change spacing. I would recommend a refresh and testing if possible.

[shailu25]

Updated Patch.

[shailu25]

In 59919.4.patch I have inherited the pull quote's font size and line height from both the front-end and editor sides when custom font size and line height are selected in the editor.

[karmatosed]

I am going to assign this to myself for testing. Thank you everyone.

[karmatosed]

In 58907:

Twenty Sixteen: Fixes pullquote block typography not working.

The pullquote block was not reflecting the typography changes. This updated patch keeps the size and also fixes the line height.

Props pranitdugad, nidhidhandhukiya, jorbin, darshitrayaguru97, yurajsinj2211, ankit-k-gupta, poena, sabernhardt, shailu25.
Fixes #59919.