Make WordPress Core

Opened 4 months ago

Last modified 3 weeks ago

#59919 new defect (bug)

Twenty Sixteen : PullQuote block Typography option is not working properly

Reported by: pranitdugad's profile pranitdugad Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-testing-info changes-requested
Focuses: css Cc:

Description

In Twenty Sixteen, The PullQuote block Typography option is not working properly. if we compare it with other themes when we change the typography size the whole content of the PullQuote Block changes.
Here is the Video for proper understanding :
https://drive.google.com/file/d/1oFolq5vcgiZVZlXfMV-k5Q34If3m6N61/view?usp=sharing

Attachments (1)

59919.patch (1.9 KB) - added by nidhidhandhukiya 4 months ago.

Download all attachments as: .zip

Change History (9)

#1 @pranitdugad
4 months ago

  • Summary changed from Twenty Sixteen : PullQoute block Typography option is not working properly to Twenty Sixteen : PullQuote block Typography option is not working properly

#2 @jorbin
3 months ago

  • Focuses css added
  • Keywords has-patch needs-testing added; has-screenshots removed
  • Milestone changed from Awaiting Review to 6.5

Thank you @pranitdugad for the ticket and @nidhidhandhukiya for the patch.

Moving to 6.5 for visibility during the next core cycle.

For testing, I think it's important to ensure that 1) Existing Pull Quotes look the same on the front end and 2) the controls in the editor work as expected.

#3 @darshitrajyaguru97
3 months ago

Test Report for https://core.trac.wordpress.org/attachment/ticket/59919/59919.patch

Environment:
============
PHP: 8.1.9
WordPress: 6.4
Browser: Chrome
Theme: Twenty Sixteen
Plugin: none

Screenshots:
===========
Before Patch Screenshots:
Backend: https://prnt.sc/JoV4am2Ctlqz
Frontend: https://prnt.sc/ew6R5Jadhdmb

After Patch Screenshots:
Backend: https://prnt.sc/nd15M05cvhTl
Frontend: https://prnt.sc/WbTSZe6aYdP2

Patch is working well.

#4 @yuvrajsinh2211
3 months ago

Testing of: https://core.trac.wordpress.org/attachment/ticket/59919/59919.patch

Tested in the below environment:

PHP: 8.1.9
WordPress: 6.4
Theme: Twenty-Sixteen
Browser: Chrome
Plugin: No plugins


Before Patch Screenshot:

Backend: https://prnt.sc/u5ukHAPft3DK
Frontend: https://prnt.sc/QV1KbXhqnToY


After-Patch Screenshot:

Backend: https://prnt.sc/CP0JPCKQ7gHi
Frontend: https://prnt.sc/xSGGn9JP-OO-

As tested, Patch is working properly.

#5 @Ankit K Gupta
3 months ago

Test Report ✅

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/59919/59919.patch

Environment

  • WordPress: 6.5-alpha-20231215.233054
  • PHP: 7.4.30
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 5.7.28 / Client: mysqlnd 7.4.30)
  • Browser: Chrome 120.0.0.0
  • OS: macOS
  • Theme: Twenty Sixteen 3.1
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.0.0

Actual Results

✅ Issue resolved with patch.

Before the Fix/patch:

https://screencast-o-matic.com/watch/c0loFiVHnlz

After the Fix/patch:

https://screencast-o-matic.com/watch/c0loFXVHnlW

#6 @Ankit K Gupta
3 months ago

  • Keywords has-testing-info added; needs-testing removed

#7 @poena
4 weeks ago

  • Keywords changes-requested added

Hi
Thank you for working on this ticket.
I have tested patch https://core.trac.wordpress.org/attachment/ticket/59919/59919.patch and would like to make the following change requests:

  • The patch removes the font size from both the pullquote block and the blockquote HTML element.

This means that the quote added in the classic editor, and the quote block, are also affected, not only the pullquote block.
Expected: The classic quote and quote block should remain unchanged or be improved.

  • When the font-size option is not used, the font size does not match the previous size.

So the default size is smaller than it was before the patch, and this is an unexpected change on live websites.
Expected: The default font size for both the pullquote content and the cite should be the same as before the patch.

  • When the font-size option is not used, the sizes in the editor and front does not match.

Expected: The editor and front should match.


Note: When the font size is removed, the block uses the default font size that WordPress adds here:
https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/pullquote/block.json#L67
But this only works on the front.

#8 @poena
3 weeks ago

  • Milestone changed from 6.5 to Future Release
Note: See TracTickets for help on using tickets.