WordPress.org
Get WordPress

Make WordPress Core

Opened 11 months ago

Closed 8 months ago

#59929 closed defect (bug) (fixed)

Use post_password_required() for comment capability checks

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by:
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.3.2
Component: Comments Keywords: has-patch commit
Focuses: Cc:

Description

[56836] introduced a few capability checks with ! empty( $post->post_password ).

Generally, we use post_password_required() for similar checks elsewhere in core.

Unless I'm missing something, it can be used here as well.

Follow-up to [56836], [57123].

Attachments (1)

59929.diff​ (2.0 KB) - added by SergeyBiryukov 11 months ago.

Download all attachments as: .zip

Change History (4)

@SergeyBiryukov
11 months ago

This ticket was mentioned in ​Slack in #core by rajinsharwar. ​View the logs.
8 months ago

#2 @rajinsharwar
8 months ago

  • Keywords commit added

Thank you for the patch @SergeyBiryukov. I guess we can get this reviewed and committed soon within this cycle. Marking this for commit.

#3 @SergeyBiryukov
8 months ago

  • Resolution set to fixed
  • Status changed from new to closed

This was fixed in [57285], the commit missed the ticket.

Note: See TracTickets for help on using tickets.