#59931 closed defect (bug) (fixed)
PHPunit test for _wp_mysql_week()
Reported by: | pbearne | Owned by: | jorbin |
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | 3.0 |
Component: | Build/Test Tools | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Description
Change History (7)
This ticket was mentioned in PR #5682 on WordPress/wordpress-develop by @pbearne.
12 months ago
#2
- Keywords has-patch has-unit-tests added
#4
@
11 months ago
- Milestone changed from Awaiting Review to 6.5
- Version set to 3.0
Introduced in [14499] for ticket #10397.
The second param of WEEK isn't the day of the week, it's the mode while the start_of_week
option is the "first day of the week" and accepts any day as the first.
Milestoning for commit consideration.
#5
@
11 months ago
- Owner set to jorbin
- Resolution set to fixed
- Status changed from new to closed
In 57207:
@SergeyBiryukov commented on PR #5682:
10 months ago
#7
Thanks for the PR! This was merged in r57207.
Note: See
TracTickets for help on using
tickets.
I have the test for this function as it is
But I am confused why we use DATE_SUB function and not just return the 2 to 6 as the 2nd parm of the week function?