Make WordPress Core

Opened 16 months ago

Closed 16 months ago

Last modified 14 months ago

#59933 closed defect (bug) (reported-upstream)

AM/PM translation dont work

Reported by: ebrockway's profile EBrockway Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.5
Component: General Keywords: close
Focuses: Cc:

Description

Hi,

Could we have the "AM" and "PM" string added to the language files as it is?

Regards

Change History (6)

#1 @tobifjellner
16 months ago

  • Keywords reporter-feedback added
  • Severity changed from critical to normal

Can you be more specific about where you see a problem?
If you look at the current build of WordPress trunk you'll find in
https://build.trac.wordpress.org/browser/trunk/wp-includes/class-wp-locale.php
the following lines:


	                // The meridiems.
$this->meridiem['am'] = __( 'am' );
$this->meridiem['pm'] = __( 'pm' );
$this->meridiem['AM'] = __( 'AM' );
$this->meridiem['PM'] = __( 'PM' );

#2 @amans2k
16 months ago

  • Version set to trunk

Hello @tobifjellner,

Thanks for the response.

Let me brief the problem.

DateTimePicker WordPress component
http://imgwxl.com/a/2023-11-21-10:23:10.png

It outputs AM and PM string

  • English US view

http://imgwxl.com/a/2023-11-21-10:19:29.png

  • Spanish view

http://imgwxl.com/a/2023-11-21-10:18:09.png

  • But in the French view, AM and PM translation is empty with space

http://imgwxl.com/a/2023-11-21-10:16:00.png

It should show the same AM PM or the translated string, but shouldn't be blank.

French users are unable to find what it is as it is blank.

Kindly look into it.

Thanks!

#3 @tobifjellner
16 months ago

  • Keywords reporter-feedback removed

Thanks a lot for this information, @amans2k

So this is not a WordPress core problem, but a translation issue.
I can see that this is the case for #fr_FR and #fr_BE (but not for Canadian French).

I guess the reason is that these translation teams took for granted that sites with their languages will always use 24 hour system. But in form components this may not always be the case.

I have used the respective locale tags in my comment to notify the Translation Editors for these language variants about the problem.

Ref for fr_FR:

Ref for fr_BE:

Actually any logged-in user here can suggest translations for these strings. So I invite you, @EBrockway to do that for these 8 strings. Once done, you can close this ticket as "Reported upstream". :)

#4 @tobifjellner
16 months ago

  • Keywords close added

#5 @EBrockway
16 months ago

  • Resolution set to reported-upstream
  • Status changed from new to closed

Done @tobifjellner :)

#6 @swissspidy
14 months ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.