Twenty Twenty-Four: PHPCS: Empty line required before block comment

[pratikharadava]

I have fixed Empty line required before block the comment PHPCS issue on the twenty-twentyfour theme's function file.

[SergeyBiryukov]

Hi there, welcome to WordPress Trac! Thanks for the ticket.

Could you clarify how you run the PHPCS checks?

When running WPCS checks for WordPress core with the default phpcs.xml.dist​ file, Twenty Twenty-Four appears to pass all the checks successfully in my testing.

[sabernhardt]

moving the comments before register_block_style

[sabernhardt]

I did not find a spacing requirement before comments in the ​handbook.

Twenty Twenty-One added comments before each register_block_style function, though those arrays do not include inline_style. If it's worth moving the comments earlier in Twenty Twenty-Four, I found some related issues and pull requests to fill in the rest of the comments (and adjusted the quotes).

[karmatosed]

I am torn working out if this is worth it, although I do recognize we have a patch. @SergeyBiryukov you are saying we pass the checks. Does that mean we don't need to have this diff, or @sabernhardt would it be good to get in as a refinement? I am happy either way but want to just make sure we have a consensus on this.

[sabernhardt]

I do not find the changes necessary, but the ticket type is 'enhancement'. It might be nicer with them.

[karmatosed]

For now I am going to recommend that this is closed because it does pass the checks and the theme has been out for a while. That said if anyone would wish to counter this please do and it can always be reversed. Thank you everyone for the collaboration here.

[karmatosed]

I am going to close this for now. Thank you everyone for collaboration so far.