Make WordPress Core

Changes between Initial Version and Version 13 of Ticket #59960


Ignore:
Timestamp:
06/10/2024 07:08:56 PM (18 months ago)
Author:
sabernhardt
Comment:

I'm not comfortable with changing all of these during beta. I do not even know where to find some of these elements.

To test, compare each admin screen before and after applying the patch. First, go to your browser settings and set a minimum font size of 16 to 20 to discover how the page changes without the unit. Then test again without the minimum font size to make sure the difference with the patch is not too much (as it seemed for the popular-tags section).

I had mentioned the iframe-based editor earlier because that is how I first noticed the small line-height, but I do not recommend testing PR 5719 in it. The main issue there is that admin body styles should not apply at all in the iframe (GB57176).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #59960

    • Property Keywords has-patch needs-testing added; needs-patch removed
    • Property Milestone changed from Awaiting Review to 6.7
  • Ticket #59960 – Description

    initial v13  
    11Follow-up to #44643
    22
    3 The default `line-height` of `1.4em` can cause issues, at least in the iframe-based editor. Other instances probably could be unitless too (while keeping their numeric value).
     3The default `line-height` of `1.4em` can cause issues, at least when elements within the `body` have a larger font size than their container ~~in the iframe-based editor~~. Other instances probably could be unitless too (while keeping their numeric value).
    44
    55{{{